Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused by comment in configuration file (min_fan1_speed and max_fan1_speed) #262

Open
whxvd opened this issue Oct 18, 2023 · 2 comments
Open

Comments

@whxvd
Copy link

whxvd commented Oct 18, 2023

The default mbpfan.conf contains:

#min_fan1_speed = 2000	# put the *lowest* value of "cat /sys/devices/platform/applesmc.768/fan*_min"
#max_fan1_speed = 6200	# put the *highest* value of "cat /sys/devices/platform/applesmc.768/fan*_max"

Shouldn't it be min_fan_speed and max_fan_speed instead of min_fan1_speed and max_fan1_speed?

@whxvd
Copy link
Author

whxvd commented Oct 19, 2023

I was confused, because the default mbpfan.conf mentiones https://ineed.coffee/post/a-beginners-tutorial-for-mbpfan-under-ubuntu, which uses the names without numbers, and because the advice in the default mbpfan.conf ("put the ... value of "cat /sys/devices/platform/applesmc.768/fan*_...") makes most sense when all fan speeds would be set together.

Another problem is, that the daemon does not give an error message, when the configuration file uses an unsupported name. E.g., I can write a line troet = 23 in it, restart the service, and the logs says nothing. So that could not be used to disambiguate.

However, for now I assume it is as the other comments in the default configuration file say: Every fan is set individually, and there is no min/max setting for all fans at once (anymore). I now just use the defaults from the SMC, i.e., no explicit setting.

@HackerPide
Copy link

The default mbpfan.conf contains:

#min_fan1_speed = 2000	# put the *lowest* value of "cat /sys/devices/platform/applesmc.768/fan*_min"
#max_fan1_speed = 6200	# put the *highest* value of "cat /sys/devices/platform/applesmc.768/fan*_max"

Shouldn't it be min_fan_speed and max_fan_speed instead of min_fan1_speed and max_fan1_speed?

That seems to be the case. My mbpfan service fails to run with the numbers in the variable names but works as expected without them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants