Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combinational Analysis Not Fully Minimizing #1889

Open
UsrRed7 opened this issue Oct 12, 2023 · 4 comments
Open

Combinational Analysis Not Fully Minimizing #1889

UsrRed7 opened this issue Oct 12, 2023 · 4 comments
Assignees
Labels
bug Yep, that's an insect. enhancement help wanted pri -1 Not that crucial (lower priority)

Comments

@UsrRed7
Copy link

UsrRed7 commented Oct 12, 2023

Working with a 4 bit input, some desired outputs aren't fully minimized.

Some examples:

  1. Data: [1, 0, 1, 1, 0, 1, 1, 0 , 1, 1, 0, 1, 1, 1, 1, 0]
    Formula: bc'd+a'b'd'+a'b'c+a'cd'+b'c'd'+ab'd+ac'+bcd'
    The K-map generated:
image
  1. Data: [0011111011110111]
    Formula: b'c+ab'+a'bc'+a'bd'+bc'd+cd'+ad
    The K-map generated:
image

I haven't looked at the code at all, but if pointed in the right direction I may be able to help track down the reason for this issue.

@maehne maehne added bug Yep, that's an insect. enhancement help wanted pri -1 Not that crucial (lower priority) labels Oct 16, 2023
@maehne
Copy link
Member

maehne commented Oct 16, 2023

Thanks for reporting the issue. Indeed, the form is not minimal, but at least correct. We highly appreciate any help to improve the optimization algorithm. The relevant code lives in src/main/java/com/cburch/logisim/analyze/. PRs are always welcome!

@superenginegit
Copy link
Contributor

If no one is working on it, I would like to work on it.

@maehne
Copy link
Member

maehne commented Nov 28, 2023

@superenginegit: Thanks for volunteering! No one is currently working on this issue and the related issue #1914 (which I am at the moment not able to reproduce). Feel free to open a PR as soon as you would like feedback from us. You can mark it as draft als long it is not ready for merging. For the moment, I will assign you the issue.

@davidhutchens
Copy link
Member

@UsrRed7: Could you try the latest Nightly build to see if this issue was fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Yep, that's an insect. enhancement help wanted pri -1 Not that crucial (lower priority)
Projects
None yet
Development

No branches or pull requests

4 participants