Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Changes in media-specific styles are not picked up when printing #76

Closed
lojjic opened this issue Sep 7, 2010 · 5 comments
Closed

Changes in media-specific styles are not picked up when printing #76

lojjic opened this issue Sep 7, 2010 · 5 comments

Comments

@lojjic
Copy link
Owner

lojjic commented Sep 7, 2010

If a page has print-specific styles that change the appearance of elements when printing, PIE will not detect the changes so the rendering stays the same as the screen version.

This might be as simple as adding an onbeforeprint listener which invokes the onpropertychange listener for each element.

Forum posting at http://css3pie.com/forum/viewtopic.php?f=3&t=160

@lojjic
Copy link
Owner Author

lojjic commented Nov 3, 2010

There is now logic in place which clears out any PIE rendering, reverting all elements to their default CSS, when printing. That makes this issue moot; closing.

@EttuDevelopers
Copy link

Hi,

I see that this issue is fixed. Can you help me with the code for the fix because i have this issue in a site that go's live in a few days.

@lojjic
Copy link
Owner Author

lojjic commented Nov 9, 2010

What help do you need?

@EttuDevelopers
Copy link

I was curious what change you did to fix this.
But in the meantime i think i already found the solution, is this the correct one?

var vmlContainer = vmlDoc.createElement(vmlPrefix + ':' + tag);
vmlContainer.print = 'false';
return vmlContainer;

@lojjic
Copy link
Owner Author

lojjic commented Nov 9, 2010

No the official fix was more involved than that, it actually reverts everything when printing rather than just hiding the VML. Here is the commit: 828dac6 -- however that's not going to be much use to you if you're trying to patch beta2 because it's based on much later code. Your best bet would be to pull down the current master code and build it.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants