Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider releasing a 1.0.0 #375

Open
PowerKiKi opened this issue Jun 8, 2018 · 5 comments
Open

Consider releasing a 1.0.0 #375

PowerKiKi opened this issue Jun 8, 2018 · 5 comments

Comments

@PowerKiKi
Copy link

This project is now more than 6 years old and should probably be considered "production ready" at this point. As the project claims to follow semver, you should probably consider releasing the next version as 1.0.0 to convey the maturity of the project and follow semver rules.

@matthutchinson
Copy link
Member

Good point! @mroth how do you feel about bumping the version to 1.0 - now that I've extracted all the plugins. Or was that something you wanted to hold off doing until this (now old) refactoring PR is complete?

@mroth
Copy link
Member

mroth commented Jun 11, 2018

Hmm. I do agree we're close to the time we should do a 1.0. Looking at #343 I do also think that if we can make it happen, doing so before a 1.0 release is the right time, because afterwards we'll want to keep the format fairly consistent. #343 would also greatly increase the usability I think, so maybe let's review it, see what it would take, and either go forward with it and reject it.

Off the top of my head, the road to v1.0 stuff would then be:

  • Review and merge/reject Discussion: CLI UI refactoring #343
  • Documentation/README/website/etc cleanup
  • Finally figure out how to move core lolcommits project itself to the lolcommits organization, to reflect that this really is an effort outside of me now and that others get proper credit! :-)
  • Once we're at 1.0-ish, I'd like to consider a homebrew package to make it easy for folks to install (I'm pretty sure I know how to do this now that we're good on deps).

@matthutchinson What do you think? (We could also make a GH "project" or "milestone" or whatever it is to track towards this.)

@matthutchinson
Copy link
Member

Sounds like a plan 👍

I'll create a GitHub project towards getting v1.0 released with the steps above.

Also - one thing I've been meaning to try out is ditching ImageMagick/MiniMagick and trying Rust instead.

There are a bunch of open-source image manipulation packages available in Rus. They can be compiled to be cross-platform compatible and can easily integrate with Ruby via Helix or called by shelling out.

But... this has been on my own to-do list for quite a while and I wouldn't want it to hold up a 1.0 release... but it would be nice to drop more dependencies here...

@matthutchinson
Copy link
Member

Project created: https://github.com/mroth/lolcommits/projects/2

@matthutchinson
Copy link
Member

Also - I'll see whats required to resolve the conflicts on #343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants