Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fill_polygon accept floats #131

Open
baloe opened this issue May 16, 2022 · 2 comments
Open

make fill_polygon accept floats #131

baloe opened this issue May 16, 2022 · 2 comments

Comments

@baloe
Copy link

baloe commented May 16, 2022

Right now mahotas.polygon.fill_polygon requires input points to be integer-typed. That's quite restrictive.

@luispedro
Copy link
Owner

I actually agree. The code does work with integer-valued inputs, though.

@baloe
Copy link
Author

baloe commented May 17, 2022

I don't actually know the code behind fill_polygon, but I was wondering: fill_polygon probably considers the actual (float-valued) locations along the polygon lines, does it not? In that case it seems like a low-hanging fruit to also enable float-valued coordinates for the description of those polygon segment end point nodes.

I ended up using skimage.draw.polygon, which solved the problem for me. So feel free to close this issue.

@baloe baloe changed the title make fill_polygon accecpt floats make fill_polygon accept floats May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants