Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package broken on current TeX Live #474

Closed
ArchangeGabriel opened this issue Feb 15, 2024 · 10 comments
Closed

Package broken on current TeX Live #474

ArchangeGabriel opened this issue Feb 15, 2024 · 10 comments
Labels
bug Something isn't working
Milestone

Comments

@ArchangeGabriel
Copy link

ArchangeGabriel commented Feb 15, 2024

After upgrading my TeX Live install today, which included https://tug.org/svn/texlive?revision=69870&view=revision, I’m facing an error compiling any document that use tabularray:

(/usr/local/texlive/2023/texmf-dist/tex/latex/tabularray/tabularray.sty
(/usr/local/texlive/2023/texmf-dist/tex/latex/l3kernel/expl3.sty
(/usr/local/texlive/2023/texmf-dist/tex/latex/l3backend/l3backend-luatex.def))
! Undefined control sequence.
<argument> \g__tblr_defined_hdash_styles_prop 
                                   
l.1089 ...yval:Nn \g__tblr_defined_hdash_styles_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_defined_vdash_styles_prop 
                                   
l.1091 ...yval:Nn \g__tblr_defined_vdash_styles_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_table_prop 
                            
l.2956 ...from_keyval:Nn \g__tblr_initial_table_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_rows_prop 
                           
l.2962 ..._from_keyval:Nn \g__tblr_initial_rows_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_columns_prop 
                              
l.2973 ...om_keyval:Nn \g__tblr_initial_columns_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_cells_prop 
                            
l.2982 ...from_keyval:Nn \g__tblr_initial_cells_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_hlines_prop 
                             
l.2992 ...rom_keyval:Nn \g__tblr_initial_hlines_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_vlines_prop 
                             
l.2997 ...rom_keyval:Nn \g__tblr_initial_vlines_prop
                                                  
? 
)

Since the issue came with the l3kernel update, I’ve also reported it at latex3/latex3#1458.

@josephwright
Copy link

As I've commented in the matching latex3/latex3 issue, this is because e.g. \prop_gset_from_keyval:Nn is being used with a variable that's not been declared first.

@cpierquet
Copy link

Same here, I hope there's be a fix for it :-)

@davidcarlisle
Copy link

Same here, I hope there's be a fix for it :-)

you just need to pre-declare the prop's, this is enough (I think)

\documentclass{article}


\ExplSyntaxOn
\prop_new:N\g__tblr_defined_hdash_styles_prop
\prop_new:N\g__tblr_defined_vdash_styles_prop
\prop_new:N\g__tblr_initial_table_prop
\prop_new:N\g__tblr_initial_rows_prop
\prop_new:N\g__tblr_initial_columns_prop
\prop_new:N\g__tblr_initial_cells_prop
\prop_new:N\g__tblr_initial_hlines_prop
\prop_new:N\g__tblr_initial_vlines_prop
\ExplSyntaxOff
\usepackage{tabularray}
\begin{document}

\end{document}

@cpierquet
Copy link

cpierquet commented Feb 15, 2024

\ExplSyntaxOn
\prop_new:N\g__tblr_defined_hdash_styles_prop
\prop_new:N\g__tblr_defined_vdash_styles_prop
\prop_new:N\g__tblr_initial_table_prop
\prop_new:N\g__tblr_initial_rows_prop
\prop_new:N\g__tblr_initial_columns_prop
\prop_new:N\g__tblr_initial_cells_prop
\prop_new:N\g__tblr_initial_hlines_prop
\prop_new:N\g__tblr_initial_vlines_prop
\ExplSyntaxOff

Yes, obviously, tks for tip :-)

Edit : it's working ;-)

@lvjr
Copy link
Owner

lvjr commented Feb 15, 2024

There will be a new release soon. At this time please download the latest package file
https://github.com/lvjr/tabularray/raw/main/tabularray.sty
and replace the old one with it.

@lvjr
Copy link
Owner

lvjr commented Feb 15, 2024

Recently I discovered that there is Hyrum's Law:

With a sufficient number of users of an API,
it does not matter what you promise in the contract:
all observable behaviors of your system
will be depended on by somebody.

So maybe tabularray is not the only broken package.

@dbitouze
Copy link
Contributor

So maybe tabularray is not the only broken package.

Indeed, e.g. acro is affected as well.

@josephwright
Copy link

Indeed, but this are definitely bugs in the relevant packages not in expl3

@lvjr
Copy link
Owner

lvjr commented Feb 15, 2024

@josephwright Is it a good idea to add test files for most maintained packages (only check whether these packages can be loaded with no error when a new latex release is made) to latex3 (also latex2e) repository so that these crashes could be fixed before users discover them?

@josephwright
Copy link

@lvjr We've considered that before but it's not workable: changes in packages would lead to breakage we can't track, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants