-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: hyperkit go bindings. #189
base: master
Are you sure you want to change the base?
Conversation
Ref #168 |
b9b9a88
to
0a32047
Compare
OK, @zchee this should be ready for a look. I split the vendor changes into another commit to make it easier to review. |
@dlorenc Woa, I’ll check it asap. |
@dlorenc Great, I will test it out and let you know. |
- package: github.com/jceel/lib9p | ||
version: 7be3e0b914fbb2d2ecfe2984d02bacfd8e762eae | ||
- package: github.com/zchee/go-vmnet | ||
- package: github.com/moby/hyperkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put version v0.20170425 so that each iteration shouldn't get from master.
- package: github.com/moby/hyperkit
version: v0.20170425
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually need 62fb993cc65090d3efe29e9b1ed871b017eeaa4d, it contains a PR I submitted yesterday to add support for qcow and sparsebundle disks. What's the best way to pin to that in glide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlorenc Then you just put this hash as version. Below should work.
- package: github.com/moby/hyperkit
version: 62fb993cc65090d3efe29e9b1ed871b017eeaa4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks!
@zchee have you had a chance to look here? |
Congrats! |
@dlorenc :D |
@dlorenc I'll check today |
@dlorenc I compiled from your PR and tried to provision
|
@praveenkumar Ah, sorry. I"ll reply tomorrow. |
This isn't fully ready yet, but I was able to get minikube booting with it.