Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotFound not triggered. #1

Open
fooman opened this issue Jul 9, 2019 · 1 comment
Open

NotFound not triggered. #1

fooman opened this issue Jul 9, 2019 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fooman
Copy link

fooman commented Jul 9, 2019

When using the sandbox I was not able to get to display the 404 page. I am guessing it's missing something in the upward.yml file.

To reproduce open sandbox
image

change url to something that should be missing and hit enter, observe that the page does not include "Page not found!"
image

@jcalcaben
Copy link
Collaborator

@fooman Good catch! This project started using the steps in the hello upward tutorial, so that path is still in the upward file but is no longer used in the main application.

I'm open to any PR solution of bringing this path back though.

@jcalcaben jcalcaben added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants