Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently viewed #39

Open
magma1447 opened this issue Nov 29, 2016 · 6 comments
Open

Recently viewed #39

magma1447 opened this issue Nov 29, 2016 · 6 comments
Assignees

Comments

@magma1447
Copy link
Owner

Geocaching.com's recently viewed is a nice feature, but hard to access.

I imagine a pull down menu that always is available where the last viewed geocaches are visible (type-icon, gccode, name).

This requires two api method. One for appending to the recently viewed list and one to fetch the current list. Since these are likely to be called at the same time when a cache page is loaded server side should ensure we fetch the list before we add a new item. Depends #23

A future addition might be that one can manually add to the list from map tooltips for example.

Ultimately it should have a better name than recently viewed, to not confuse it with Geocaching.com's version. Also if one can add manually, it's not a suiting name.

@magma1447
Copy link
Owner Author

Maybe it should be named "Stored geocaches".

I imagine two settings here. Turn the dropdown box on/off (ie this whole feature). And another setting for automatically storing caches on cache page load. If auto is off, the dropdown should have an option to store current the geocache.

@pkubiak
Copy link

pkubiak commented Nov 29, 2016

I think that this feature could be also implemented without any api calls and only by requesting https://www.geocaching.com/my/recentlyviewedcaches.aspx and parsing its content. Of course this way we wouldn't be able to manipulate this data, but on the other hand it will be more failproof (will be collecting data on any device, eg. browser, cgeo, ...).

@pkubiak
Copy link

pkubiak commented Nov 29, 2016

Something like that would be possible with pure geocaching request:
screenshot_2016-11-29_18-39-39

@magma1447
Copy link
Owner Author

I think this looks great, a much better approach at a very small loss. You are most welcome to make a pull request with that patch.

@Jakuje
Copy link
Contributor

Jakuje commented Dec 4, 2016

I like the usability improvement in this, but I am not sure if I want it by default and always.

In which state this change is? It is getting the content of recentlyviewedcaches.aspx with every load of every page? That sounds very big overhead both on the client and server. But it is hard to cache this data, since we really want the recent caches ...

@magma1447
Copy link
Owner Author

In theory the list could be fetched when actually clicking the button. Though I am unsure if that can be managed with Greasemonkey. It would require an event to be triggered when clicking that button.

As all other improvements with the script I wish for an on/off setting. I believe the default can very well be yes if we don't make an extra page load on each request, otherwise maybe we should keep it off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants