Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tecmo/bombjack.cpp: Refactor, merge with sega/calorie.cpp #12476

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

jackson2k2
Copy link
Contributor

@jackson2k2 jackson2k2 commented Jun 12, 2024

  • Reduce literal tag usage
  • Fix large sprites in Bomb Jack by implementing the sprite size latches
  • Simplify and fix gfxdecode macros for Bomb Jack
  • Fix background tilemap loading in Bomb Jack to properly use D0-D3
  • Fix memory maps to match the schematics
  • Add watchdog timer reset and enable (not present in Calorie Kun)
  • Proper screen params for Bomb Jack and Calorie Kun
  • Proper audio timings for Calorie Kun, verified against PCB video
  • Add notes on LM324/CD4066 audio filter for each channel + PCB references
  • Cleaned up other notes, fix spacing

Also rename set bombjack2 to "Bomb Jack (earlier)" and change "licence" -> "license" for bombjackt.

- Fix large sprites in Bomb Jack by implementing the sprite size latches
- Simplify and fix gfxdecode macros for Bomb Jack
- Fix background tilemap loading in Bomb Jack to properly use D0-D3
- Fix memory maps to match the schematics
- Add watchdog reset and enable (not used in Calorie Kun)
- Proper screen params for Bomb Jack and Calorie Kun
- Proper audio timings for Calorie Kun
- Add notes on audio filter and PCB references
- Cleaned up other notes
- Fixed spacing

- Also renamed bombjack2 to "Bomb Jack (earlier)"
- Also renamed "licence" to "license" in bombjackt
@rb6502 rb6502 merged commit c724772 into mamedev:master Jun 14, 2024
4 of 5 checks passed
@jackson2k2 jackson2k2 deleted the bombjack branch June 15, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants