Skip to content

Commit

Permalink
[10544] Output debug only note for known not implemented packets
Browse files Browse the repository at this point in the history
This is packets that have allowed to receive setting (not STATUS_NEVER)
and WorldSession::Handle_NULL handler.

Mark some packets in this way.
  • Loading branch information
VladimirMangos committed Sep 26, 2010
1 parent d512b1e commit 0d5b653
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/game/Opcodes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -904,10 +904,10 @@ OpcodeHandler opcodeTable[NUM_MSG_TYPES] =
/*0x36B*/ { "CMSG_LFG_SET_NEEDS", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x36C*/ { "CMSG_LFG_SET_BOOT_VOTE", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x36D*/ { "SMSG_LFG_BOOT_PLAYER", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x36E*/ { "CMSG_LFD_PLAYER_LOCK_INFO_REQUEST", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x36E*/ { "CMSG_LFD_PLAYER_LOCK_INFO_REQUEST", STATUS_LOGGEDIN, &WorldSession::Handle_NULL },
/*0x36F*/ { "SMSG_LFG_PLAYER_INFO", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x370*/ { "CMSG_LFG_TELEPORT", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x371*/ { "CMSG_LFD_PARTY_LOCK_INFO_REQUEST", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x371*/ { "CMSG_LFD_PARTY_LOCK_INFO_REQUEST", STATUS_LOGGEDIN, &WorldSession::Handle_NULL },
/*0x372*/ { "SMSG_LFG_PARTY_INFO", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x373*/ { "SMSG_TITLE_EARNED", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x374*/ { "CMSG_SET_TITLE", STATUS_LOGGEDIN, &WorldSession::HandleSetTitleOpcode },
Expand Down
4 changes: 2 additions & 2 deletions src/game/WorldSession.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ const char * WorldSession::GetMangosString( int32 entry ) const

void WorldSession::Handle_NULL( WorldPacket& recvPacket )
{
sLog.outError( "SESSION: received unhandled opcode %s (0x%.4X)",
DEBUG_LOG("SESSION: received unimplemented opcode %s (0x%.4X)",
LookupOpcodeName(recvPacket.GetOpcode()),
recvPacket.GetOpcode());
}
Expand All @@ -541,7 +541,7 @@ void WorldSession::Handle_EarlyProccess( WorldPacket& recvPacket )

void WorldSession::Handle_ServerSide( WorldPacket& recvPacket )
{
sLog.outError( "SESSION: received server-side opcode %s (0x%.4X)",
sLog.outError("SESSION: received server-side opcode %s (0x%.4X)",
LookupOpcodeName(recvPacket.GetOpcode()),
recvPacket.GetOpcode());
}
Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "10543"
#define REVISION_NR "10544"
#endif // __REVISION_NR_H__

1 comment on commit 0d5b653

@Andrewzz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this is what I thing, Great this will reduce the console spam a lot :D
I am not sure, but this wasnt affecting performance in a hight loaded server when several users make the console spam this lot of times?

Please sign in to comment.