Skip to content

Commit

Permalink
[9819] Rename some more opcodes.
Browse files Browse the repository at this point in the history 
Also fix the name of some older opcodes that were marked as obsolete but no longer are.
  • Loading branch information
XTZGZoReX committed May 1, 2010
1 parent 1671f0a commit 365e2fe
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
14 changes: 7 additions & 7 deletions src/game/Opcodes.cpp
View file
Expand Up @@ -856,9 +856,9 @@ OpcodeHandler opcodeTable[NUM_MSG_TYPES] =
/*0x33B*/ { "SMSG_INSTANCE_DIFFICULTY", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x33C*/ { "MSG_GM_RESETINSTANCELIMIT", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x33D*/ { "SMSG_MOTD", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x33E*/ { "SMSG_MOVE_SET_FLIGHT_OBSOLETE", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x33F*/ { "SMSG_MOVE_UNSET_FLIGHT_OBSOLETE", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x340*/ { "CMSG_MOVE_FLIGHT_ACK_OBSOLETE", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x33E*/ { "SMSG_MOVE_SET_FLIGHT", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x33F*/ { "SMSG_MOVE_UNSET_FLIGHT", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x340*/ { "CMSG_MOVE_FLIGHT_ACK", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x341*/ { "MSG_MOVE_START_SWIM_CHEAT", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x342*/ { "MSG_MOVE_STOP_SWIM_CHEAT", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x343*/ { "SMSG_MOVE_SET_CAN_FLY", STATUS_NEVER, &WorldSession::Handle_ServerSide },
Expand Down Expand Up @@ -1320,11 +1320,11 @@ OpcodeHandler opcodeTable[NUM_MSG_TYPES] =
/*0x50B*/ { "SMSG_UNKNOWN_1291", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x50C*/ { "UMSG_UNKNOWN_1292", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x50D*/ { "SMSG_REDIRECT_CLIENT", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x50E*/ { "CMSG_UNKNOWN_1294", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x50F*/ { "UMSG_UNKNOWN_1295", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x50E*/ { "CMSG_REDIRECTION_FAILED", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x50F*/ { "SMSG_UNKNOWN_1295", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x510*/ { "CMSG_UNKNOWN_1296", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x511*/ { "UMSG_UNKNOWN_1297", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x512*/ { "CMSG_UNKNOWN_1298", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x511*/ { "SMSG_FORCE_SEND_QUEUED_PACKETS", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x512*/ { "CMSG_REDIRECTION_AUTH_PROOF", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x513*/ { "UMSG_UNKNOWN_1299", STATUS_NEVER, &WorldSession::Handle_NULL },
/*0x514*/ { "SMSG_COMBAT_LOG_MULTIPLE", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x515*/ { "SMSG_LFG_OPEN_FROM_GOSSIP", STATUS_NEVER, &WorldSession::Handle_ServerSide },
Expand Down
12 changes: 6 additions & 6 deletions src/game/Opcodes.h
View file
Expand Up @@ -864,9 +864,9 @@ enum Opcodes
SMSG_INSTANCE_DIFFICULTY = 0x33B,
MSG_GM_RESETINSTANCELIMIT = 0x33C,
SMSG_MOTD = 0x33D,
SMSG_MOVE_SET_FLIGHT_OBSOLETE = 0x33E,
SMSG_MOVE_UNSET_FLIGHT_OBSOLETE = 0x33F,
CMSG_MOVE_FLIGHT_ACK_OBSOLETE = 0x340,
SMSG_MOVE_SET_FLIGHT = 0x33E,
SMSG_MOVE_UNSET_FLIGHT = 0x33F,
CMSG_MOVE_FLIGHT_ACK = 0x340,
MSG_MOVE_START_SWIM_CHEAT = 0x341,
MSG_MOVE_STOP_SWIM_CHEAT = 0x342,
SMSG_MOVE_SET_CAN_FLY = 0x343,
Expand Down Expand Up @@ -1328,11 +1328,11 @@ enum Opcodes
SMSG_UNKNOWN_1291 = 0x50B, // some item update packet?
UMSG_UNKNOWN_1292 = 0x50C, // not found
SMSG_REDIRECT_CLIENT = 0x50D, // uint32 ip, uint16 port, uint32 unk, uint8[20] hash (ip + port, seed=sessionkey)
CMSG_UNKNOWN_1294 = 0x50E, // something with networking
CMSG_REDIRECTION_FAILED = 0x50E, // something with networking
SMSG_UNKNOWN_1295 = 0x50F, //
CMSG_UNKNOWN_1296 = 0x510, // something with networking
SMSG_UNKNOWN_1297 = 0x511, //
CMSG_UNKNOWN_1298 = 0x512, // something with networking
SMSG_FORCE_SEND_QUEUED_PACKETS = 0x511, //
CMSG_REDIRECTION_AUTH_PROOF = 0x512, // something with networking
UMSG_UNKNOWN_1299 = 0x513, // not found
SMSG_COMBAT_LOG_MULTIPLE = 0x514, // SMSG, multi combatlog
SMSG_LFG_OPEN_FROM_GOSSIP = 0x515, // event EVENT_LFG_OPEN_FROM_GOSSIP (opens dungeon finder, probably for outdoor bosses)
Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
View file
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "9818"
#define REVISION_NR "9819"
#endif // __REVISION_NR_H__

13 comments on commit 365e2fe

@xurxogr
Copy link

@xurxogr xurxogr commented on 365e2fe May 1, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opcodes.cpp: 0x50F and 0x511 should be &WorldSession::Handle_ServerSide

@3raZar3
Copy link

@3raZar3 3raZar3 commented on 365e2fe May 1, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unlike my comrades.. i have a very big issue with how mangos-dev can PUSH a commit without making sure that it will compile and not fuck up previous work.... Hellscream and Evo-X might worship u, but I think you are lazy bastards... you could at LEAST communicate with each other and at LEAST one main dev between you could TEST your repo against other major sub systems like Tasssadar or Hellscream.

no offense to NF... (although personally i think he/she should stay with SD2.. else my previous complaints of how MaNGOS and its sub sites rely on each other is verified and in which case i shouldn't have been banned for pointing out the obvious)

@3raZar3
Copy link

@3raZar3 3raZar3 commented on 365e2fe May 1, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know for an absolute FACT you completely ignore any work done by other accredited repos who ATTEMPT to work with you and think only of your own individual repositories

@3raZar3
Copy link

@3raZar3 3raZar3 commented on 365e2fe May 1, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont even TRY to work with each otehr else such issues wouldnt occur.... want to naysay? tell me how you push BROKEN repos... not this repo, but countless others prior

@VladimirMangos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. Why we must care about your nonsense? Why we must care about forks?

@alexrp
Copy link

@alexrp alexrp commented on 365e2fe May 2, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3raZar3: I won't comment on your opinion about the MaNGOS team, but just tell me how these statements even remotely relate to this commit...?

@kero99
Copy link

@kero99 kero99 commented on 365e2fe May 2, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3raZar3: If you use a fork or I use a fork is your and me problem... not mangos-dev problem. All forks will be thankful of their wonderful work.. not the other way.

Best Regards

@3raZar3
Copy link

@3raZar3 3raZar3 commented on 365e2fe May 2, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont use a fork :)

@Tasssadar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3raZar3, please, dont drag me into this, ok? :)

@Ligthguard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't use a fork and you do not like MaNGOS and the devs anyways, then why are you actually writing this here? As Vladimir said before, why would we care about your words? Your comment seems totally unrelated and pointless, not to mention that you're somewhat rude and involving ppl who didn't ask to be the part of this, right?

@3raZar3
Copy link

@3raZar3 3raZar3 commented on 365e2fe May 2, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah okay my bad... disregard last 24hrs of comments

@SkyFire
Copy link

@SkyFire SkyFire commented on 365e2fe May 3, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3raZar3. I tried to see things your way, But just seem to get my head that far up my ass!

@3raZar3
Copy link

@3raZar3 3raZar3 commented on 365e2fe May 3, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess you arent trying hard enough...

listen i am not going to bicker with you or any other person replying to these commits.. I made a jackass of myself taunting the staff and for this I do solemnly apologize to the staff of mangos it will not occur again... as for thos nonstaff groupies that want to continue this arguement lets do so on my repos or through github messaging.. otherwise drop it huh? I was wrong and I can manup attempt to be civil about it, i suggest you do the same else these petty wars can never die away.. agreed?

Please sign in to comment.