-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[10589] Always activate GO type 3 when quest id is defined (and active)
GO may be "lootless", but events at looting can happen Signed-off-by: NoFantasy <nofantasy@nf.no>
- Loading branch information
NoFantasy
committed
Oct 8, 2010
1 parent
1bb78dc
commit 36f91ea
Showing
3 changed files
with
12 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#ifndef __REVISION_NR_H__ | ||
#define __REVISION_NR_H__ | ||
#define REVISION_NR "10588" | ||
#define REVISION_NR "10589" | ||
#endif // __REVISION_NR_H__ |
36f91ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not be better code to use:
if (goInfo->chest.questId || LootTemplates_Gameobject.HaveQuestLootFor(loot_id))
instead of repeating the same insert and count twice? Technically, it's the same thing but I don't see the need for extra lines.