Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[10384] Fixed reset time calculation for some cases.
Most real fix suggested by Schmoozerd and Toinan67 and some my code style part coding ;)
- Loading branch information
VladimirMangos
committed
Aug 20, 2010
1 parent
65c3249
commit 5c7707e
Showing
5 changed files
with
22 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#ifndef __REVISION_NR_H__ | ||
#define __REVISION_NR_H__ | ||
#define REVISION_NR "10383" | ||
#define REVISION_NR "10384" | ||
#endif // __REVISION_NR_H__ |
5c7707e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And still it's not blizzlike
5c7707e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more info?
5c7707e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://github.com/LordJZ/mangos/commit/fd6a244d0eea97f0fa78f524ca618cc1ba8ca503
http://github.com/LordJZ/mangos/commit/8aabe0fb9b0b3fadf5b65970c237ff36c871a952
But it's rather old
5c7707e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uint32 instanceResetOffset;
ok, but it used only for 2 maps in map.dbc for 19 hours....
5c7707e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that was just an additional feature for that patch, the main purpose was to fix reset times when the server started on the clean database
5c7707e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meaning, is i am right that you say that it not same as retial in result not using this field?
If so then i will be glad review clear patch for including this field in calculations.
In current state hard undersatnd how it connected with mapDifficulty reset times.
5c7707e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. At the moment of that commit in my repo mangos was choosing the time to respawn calculating offsets from current time when you launch the server after
truncate instance_reset
.e.g. you launch it at
30.08 23:50
, and every reset will be30.08 23:50
+1 day
or +7 days
. Probably it was fixed for the weekday, but I haven't noticed any changes about the time of day.Also, using the constant is more blizzlike as it is sent to client (see next commit)
P.S. Omg looks like I'm just f*cking you brain, I'll go do some tests with the latest core and then provide a full patch. :\