Skip to content

Commit

Permalink
[9534] Attack Power bonus for spell 64382.
Browse files Browse the repository at this point in the history 
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
  • Loading branch information
KAPATEJIb authored and VladimirMangos committed Mar 6, 2010
1 parent 676faf1 commit 98eff59
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions src/game/SpellEffects.cpp
View file
Expand Up @@ -401,6 +401,9 @@ void Spell::EffectSchoolDMG(SpellEffectIndex effect_idx)
// Heroic Throw ${$m1+$AP*.50}
else if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x0000000100000000))
damage+= uint32(m_caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.5f);
// Shattering Throw ${$m1+$AP*.50}
else if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x0040000000000000))
damage+= uint32(m_caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.5f);
// Shockwave ${$m3/100*$AP}
else if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x0000800000000000))
{
Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
View file
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "9533"
#define REVISION_NR "9534"
#endif // __REVISION_NR_H__

3 comments on commit 98eff59

@przemratajczak
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not to add this to spell_bonus_data?

@LordJZ
Copy link
Contributor

@LordJZ LordJZ commented on 98eff59 Mar 6, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK because this spell has DamageClass = SPELL_DAMAGE_CLASS_NONE, which is not affected by spell_bonus_data.

@VladimirMangos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also table for implicit spell bonuses applied after different spell modifiers apply.
Explict spell binuses named in spell description must be added in code becuse it must be added to base spell damage for later affected diff modifiers.
Use table will give wrong result.

Please sign in to comment.