Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[9089] Check explicit target correctness by all effect target modes.
All effect target modes start from client provided target data so all its must be used for checking explicit target modes. For example exist spells that have as first effect SELF non-explicit target mode. but in same time negative to explicit target. Signed-off-by: VladimirMangos <vladimir@getmangos.com> Also add caching IsHostileTo/IsFriendlyTo for avoid recall this not fast functions.
- Loading branch information
NetSky
authored and
VladimirMangos
committed
Dec 31, 2009
1 parent
09428eb
commit d3581f7
Showing
2 changed files
with
48 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#ifndef __REVISION_NR_H__ | ||
#define __REVISION_NR_H__ | ||
#define REVISION_NR "9088" | ||
#define REVISION_NR "9089" | ||
#endif // __REVISION_NR_H__ |
d3581f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it brokes spell http://www.wowhead.com/?spell=50842 . When i try to use it on hostile target (for example enemy player or mob) i get a error with bad target because result of SPELL_FAILED_BAD_TARGETS
d3581f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it also fixes casting some dmg spells @ friends
d3581f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
becuase i forgeo remove SELF2 when remove SELF target mode from explicit possitive targets
d3581f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both problem must be fixed in [9098].