Skip to content

Commit

Permalink
[9692] Switch to support client 3.3.3a (build 11723)
Browse files Browse the repository at this point in the history
Merge branch '330'

You need regenerate dbc/map/vmap files.

Thanks to TOM_RUS who make most work for adding 3.3.3 support. ;)
  • Loading branch information
VladimirMangos committed Apr 8, 2010
1 parent c7c8c8e commit d614ee8
Show file tree
Hide file tree
Showing 10 changed files with 25 additions and 13 deletions.
1 change: 0 additions & 1 deletion sql/333/1_characters_mail.sql

This file was deleted.

2 changes: 1 addition & 1 deletion sql/characters.sql
Expand Up @@ -21,7 +21,7 @@

DROP TABLE IF EXISTS `character_db_version`;
CREATE TABLE `character_db_version` (
`required_9687_01_characters_character_queststatus_daily` bit(1) default NULL
`required_9692_02_characters_mail` bit(1) default NULL
) ENGINE=MyISAM DEFAULT CHARSET=utf8 ROW_FORMAT=FIXED COMMENT='Last applied sql update to DB';

--
Expand Down
2 changes: 1 addition & 1 deletion sql/mangos.sql
Expand Up @@ -24,7 +24,7 @@ CREATE TABLE `db_version` (
`version` varchar(120) default NULL,
`creature_ai_version` varchar(120) default NULL,
`cache_id` int(10) default '0',
`required_9690_01_mangos_spell_proc_event` bit(1) default NULL
`required_9692_03_mangos_spell_proc_event` bit(1) default NULL
) ENGINE=MyISAM DEFAULT CHARSET=utf8 ROW_FORMAT=FIXED COMMENT='Used DB version notes';

--
Expand Down
3 changes: 3 additions & 0 deletions sql/updates/9692_01_characters_mail.sql
@@ -0,0 +1,3 @@
ALTER TABLE character_db_version CHANGE COLUMN required_9687_01_characters_character_queststatus_daily required_9692_01_characters_mail bit;

alter table `mail` add column `body` longtext CHARSET utf8 COLLATE utf8_general_ci NULL after `subject`;
@@ -1,3 +1,5 @@
ALTER TABLE character_db_version CHANGE COLUMN required_9692_01_characters_mail required_9692_02_characters_mail bit;

UPDATE `mail` LEFT JOIN `item_text` ON `mail`.`itemtextid` = `item_text`.`id` SET `mail`.`body`=`item_text`.`text`;
DELETE item_text FROM mail, item_text WHERE mail.itemtextid = item_text.id;
ALTER TABLE `mail` DROP COLUMN `itemtextid`;
@@ -1,3 +1,5 @@
ALTER TABLE db_version CHANGE COLUMN required_9690_01_mangos_spell_proc_event required_9692_03_mangos_spell_proc_event bit;

-- Rampage: now passive instead of being a proc
DELETE FROM `spell_proc_event` WHERE `entry` = 29801;
-- Unleashed Rage: now passive instead of being a proc
Expand Down
6 changes: 6 additions & 0 deletions sql/updates/Makefile.am
Expand Up @@ -106,6 +106,9 @@ pkgdata_DATA = \
9686_01_characters_character_queststatus_weekly.sql \
9687_01_characters_character_queststatus_daily.sql \
9690_01_mangos_spell_proc_event.sql \
9692_01_characters_mail.sql \
9692_02_characters_mail.sql \
9692_03_mangos_spell_proc_event.sql \
README

## Additional files to include when running 'make dist'
Expand Down Expand Up @@ -192,4 +195,7 @@ EXTRA_DIST = \
9686_01_characters_character_queststatus_weekly.sql \
9687_01_characters_character_queststatus_daily.sql \
9690_01_mangos_spell_proc_event.sql \
9692_01_characters_mail.sql \
9692_02_characters_mail.sql \
9692_03_mangos_spell_proc_event.sql \
README
14 changes: 7 additions & 7 deletions src/game/DBCStores.cpp
Expand Up @@ -622,13 +622,13 @@ void LoadDBCStores(const std::string& dataPath)
}

// Check loaded DBC files proper version
if( !sSpellStore.LookupEntry(74445) || // last added spell in 3.3.2
!sMapStore.LookupEntry(718) || // last map added in 3.3.2
!sGemPropertiesStore.LookupEntry(1629) || // last gem property added in 3.3.2
!sItemExtendedCostStore.LookupEntry(2982) || // last item extended cost added in 3.3.2
!sCharTitlesStore.LookupEntry(177) || // last char title added in 3.3.2
!sAreaStore.LookupEntry(3461) || // last area (areaflag) added in 3.3.2
!sItemStore.LookupEntry(52686) ) // last client known item added in 3.3.2
if( !sAreaStore.LookupEntry(3617) || // last area (areaflag) added in 3.3.3a
!sCharTitlesStore.LookupEntry(177) || // last char title added in 3.3.3a
!sGemPropertiesStore.LookupEntry(1629) || // last added spell in 3.3.3a
!sItemStore.LookupEntry(54860) || // last gem property added in 3.3.3a
!sItemExtendedCostStore.LookupEntry(2997) || // last item extended cost added in 3.3.3a
!sMapStore.LookupEntry(724) || // last map added in 3.3.3a
!sSpellStore.LookupEntry(76567) ) // last client known item added in 3.3.3a
{
sLog.outError("\nYou have mixed version DBC files. Please re-extract DBC files for one from client build: %s",AcceptableClientBuildsListStr().c_str());
exit(1);
Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "9691"
#define REVISION_NR "9692"
#endif // __REVISION_NR_H__
4 changes: 2 additions & 2 deletions src/shared/revision_sql.h
@@ -1,6 +1,6 @@
#ifndef __REVISION_SQL_H__
#define __REVISION_SQL_H__
#define REVISION_DB_CHARACTERS "required_9687_01_characters_character_queststatus_daily"
#define REVISION_DB_MANGOS "required_9690_01_mangos_spell_proc_event"
#define REVISION_DB_CHARACTERS "required_9692_02_characters_mail"
#define REVISION_DB_MANGOS "required_9692_03_mangos_spell_proc_event"
#define REVISION_DB_REALMD "required_9010_01_realmd_realmlist"
#endif // __REVISION_SQL_H__

11 comments on commit d614ee8

@Limur
Copy link

@Limur Limur commented on d614ee8 Apr 8, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG!!!! Great

@nanouniko
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaaanks! :P

@DoesntMatter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thanks :)

@wow-masters
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • if( !sSpellStore.LookupEntry(74445) || // last added spell in 3.3.2
    626
  •    !sMapStore.LookupEntry(718)                ||       // last map added in 3.3.2
    
    627
  •    !sGemPropertiesStore.LookupEntry(1629)     ||       // last gem property added in 3.3.2
    
    628
  •    !sItemExtendedCostStore.LookupEntry(2982)  ||       // last item extended cost added in 3.3.2
    
    629
  •    !sCharTitlesStore.LookupEntry(177)         ||       // last char title added in 3.3.2
    
    630
  •    !sAreaStore.LookupEntry(3461)              ||       // last area (areaflag) added in 3.3.2
    
    631
  •    !sItemStore.LookupEntry(52686)             )        // last client known item added in 3.3.2
    
    625
  • if( !sAreaStore.LookupEntry(3617) || // last area (areaflag) added in 3.3.3a
    626
  •    !sCharTitlesStore.LookupEntry(177)         ||       // last char title added in 3.3.3a
    
    627
  •    !sGemPropertiesStore.LookupEntry(1629)     ||       // last added spell in 3.3.3a
    
    628
  •    !sItemStore.LookupEntry(54860)             ||       // last gem property added in 3.3.3a
    
    629
  •    !sItemExtendedCostStore.LookupEntry(2997)  ||       // last item extended cost added in 3.3.3a
    
    630
  •    !sMapStore.LookupEntry(724)                ||       // last map added in 3.3.3a
    
    631
  •    !sSpellStore.LookupEntry(76567)            )        // last client known item added in 3.3.3a
    

why is that changed like that. ?

@VladimirMangos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think error output in code attached to checks describe good why its checked.

@blizbiggy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great job

@kanz
Copy link

@kanz kanz commented on d614ee8 Apr 8, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, god!
There are so many lags in 3.3.3 at offy T_T
And disconnects.

@myran2
Copy link

@myran2 myran2 commented on d614ee8 Apr 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How exactly did you get all of 3.3.3 support by only changing one of the necessary source files?
Where are all the OPCodes and Updatefields?

In any case, this is still a great release. I like being able to look at every change made every few commits.

@VladimirMangos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you known how git merge work? all other commits mixed with old master revisions. You can see its by absent [rev] mostly.

@myran2
Copy link

@myran2 myran2 commented on d614ee8 Apr 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'm pretty sure I understand now :P

I'll go take a look at the old 3.3.3 branch and see what you guys did commit by commit

@VladimirMangos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will found same in 303: when master has been periodic merge to 330 when 330 bracnh developed then master commit also instered in mixed way.
For find difference you must look at new github feature for compare branches.

Please sign in to comment.