-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[9354] Add spell efffects for dual spec.
Actual dual spec still not implemented. Credits to EnderGT for original patch. Signed-off-by: hunuza <hunuza@gmail.com>
- Loading branch information
Showing
9 changed files
with
62 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
ALTER TABLE character_db_version CHANGE COLUMN required_9349_01_characters_character_action required_9354_01_characters_character_action bit; | ||
|
||
ALTER TABLE `character_action` DROP PRIMARY KEY, ADD PRIMARY KEY(`guid`,`spec`,`button`); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#ifndef __REVISION_NR_H__ | ||
#define __REVISION_NR_H__ | ||
#define REVISION_NR "9353" | ||
#define REVISION_NR "9354" | ||
#endif // __REVISION_NR_H__ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#ifndef __REVISION_SQL_H__ | ||
#define __REVISION_SQL_H__ | ||
#define REVISION_DB_CHARACTERS "required_9349_01_characters_character_action" | ||
#define REVISION_DB_CHARACTERS "required_9354_01_characters_character_action" | ||
#define REVISION_DB_MANGOS "required_9331_01_mangos_quest_template" | ||
#define REVISION_DB_REALMD "required_9010_01_realmd_realmlist" | ||
#endif // __REVISION_SQL_H__ |
eb637ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I got confused :S It is, or It is not implemented?
If it is not, do you know if it is going to be implemented today? :D Hope yes
eb637ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note fully implemented yet, but i hope very soon. =)
eb637ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just give the mangos team some more time. We all know they do a great job. When the Dual Talent gets implemented you wont see the commit message saying "Actual dual spec still not implemented." instead you will see something like "DUAL TALENT IS IMPLEMENTED OMG!!!"
eb637ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fuuu. I'm sorry, very much respecting to developers (Vladimir - cool work always!!!), but - this is shame for MaNGOS. Patch for "dual spec" exists already a long time and worked perfectly. And on my server also. Why don't use it in "official" version (with your own fixes)?
And a long time to wait vehicles, which also work normally in a patch... It's a base features...
But anyway - cool work guys! Good luck in develop & in life :-) !
eb637ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it contains code that may have some of the following:
In any of the cases please be patient. For both, the vehicle and dual talent. You are right, this 2 are needed features but it is much more important the stability and correct code than a new feature (or old in this case actually ;) )
eb637ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for CYREX, wait and see ! ;)
eb637ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally agreed according to dual spec :P
eb637ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"And a long time to wait vehicles, which also work normally in a patch..."
One big hack can't be "normal" patch ;) without dependence work it or not...