Skip to content

Commit

Permalink
[9709] change case 0 handle for basepoints calculation
Browse files Browse the repository at this point in the history
  • Loading branch information
Laise committed Apr 9, 2010
1 parent bd963a9 commit f72f447
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/game/Unit.cpp
Expand Up @@ -11312,7 +11312,7 @@ int32 Unit::CalculateSpellDamage(Unit const* target, SpellEntry const* spellProt

switch(randomPoints)
{
case 0: break; // not used
case 0: // not used
case 1: basePoints += 1; break; // range 1..1
default:
// range can have positive (1..rand) and negative (rand..1) values, so order its for irand
Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "9708"
#define REVISION_NR "9709"
#endif // __REVISION_NR_H__

3 comments on commit f72f447

@pasdVn
Copy link
Contributor

@pasdVn pasdVn commented on f72f447 Apr 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sure, that this is correct?

@milleniumcore
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll have problems with learn spell, spell_effect_learn...
No?

@VladimirMangos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you test for say about problem? Base at our reset this way will resolve existed porblesm after drop some spell.dbc fields in 3.3.3

Please sign in to comment.