Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threading.Thread.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 #159

Open
tirkarthi opened this issue May 7, 2021 · 1 comment · May be fixed by #161 or #169
Open

threading.Thread.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 #159

tirkarthi opened this issue May 7, 2021 · 1 comment · May be fixed by #161 or #169

Comments

@tirkarthi
Copy link

Description

Ref : python/cpython#25174

System settings

  • Operating System:
  • Terminal in use:
  • Python version: 3.10
  • Halo version:
  • pip freeze output:

Error

halo/halo/halo.py:        self._spinner_thread.setDaemon(True)
halo/halo/halo_notebook.py:        self._spinner_thread.setDaemon(True)

Expected behaviour

Set daemon attribute directly
@Narendra-Neerukonda Narendra-Neerukonda linked a pull request Jun 19, 2021 that will close this issue
Open
@Ran-n Ran-n linked a pull request Feb 12, 2022 that will close this issue
Open
3 tasks
@ranelpadon
Copy link

Encounter this annoying DeprecationWarning also every time we run our custom script:

/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/halo/halo.py:497: 
DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
  self._spinner_thread.setDaemon(True)

I'm using Py3.11. Hopefully, the related PRs could be merged soon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tirkarthi @ranelpadon