Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn the concrete Unit classes into singletons #1001

Closed
mantid-builder opened this issue May 29, 2008 · 1 comment
Closed

Turn the concrete Unit classes into singletons #1001

mantid-builder opened this issue May 29, 2008 · 1 comment
Labels
Low Priority Things that you don't ever want to be done.
Milestone

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Russell Taylor

With the introduction of the axis class, Unit (and it’s subclasses) do not hold any member data. We should not, therefore, be creating multiple instances of concrete units to attach to the various axes of various workspaces. Instead, the Unit Factory should just hand out a pointer to the same instance every time a unit is created.
Despite the title of this ticket, this should probably be achieved by modifying the factory to simply hand out the address of a concrete unit if it’s previously been created, rather than by modifying the unit classes themselves.

@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 153

@mantid-builder mantid-builder added the Low Priority Things that you don't ever want to be done. label Jun 3, 2015
@mantid-builder mantid-builder added this to the Iteration 9 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Things that you don't ever want to be done.
Projects
None yet
Development

No branches or pull requests

1 participant