Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReflectometryReductionOne should correct positions #10027

Closed
2 tasks done
OwenArnold opened this issue Mar 14, 2014 · 1 comment
Closed
2 tasks done

ReflectometryReductionOne should correct positions #10027

OwenArnold opened this issue Mar 14, 2014 · 1 comment
Assignees
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocked by :

This is a simple principle: If you have known incident theta angle, and a reflection condition, i.e. theta_in == theta_out, then you can correct the detector positions accordingly.

I've avoided this problem so far, because for the multi-detector case you may have a number of 'masked' pixels, in which case there is no easily identifiable vertical centre position.

Having had a chat with Tim about this, we've agreed that if you have a range of pixels in the processing instructions, you should find the centre location and use that, along with the theta position to correct location. Corrections should still be optional.

Changes should apply to ReflectometryReductionOne, ReflectometryReductionOneAuto, CreateTransmissionWorkspace and CreateTransmissionWorkspaceAuto.

As part of this. We should also update ReflectometryReductionOne (following http://trac.mantidproject.org/mantid/ticket/9401) to calculate The OuptutTheta value if Multiple Spectrum numbers are given instead of component names.

@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry labels Jun 3, 2015
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 9184

@OwenArnold OwenArnold self-assigned this Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.2 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

No branches or pull requests

1 participant