Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inelastic planning tools - Porting Chop functionality #10147

Closed
2 tasks done
NickDraper opened this issue Apr 8, 2014 · 3 comments
Closed
2 tasks done

Inelastic planning tools - Porting Chop functionality #10147

NickDraper opened this issue Apr 8, 2014 · 3 comments
Assignees
Labels
Direct Inelastic Issues and pull requests related to direct inelastic High Priority An issue or pull request that if not addressed is severe enough to postponse a release.

Comments

@NickDraper
Copy link
Contributor

This issue was originally TRAC 9304

This ticket is blocked by :

Includes porting Horace Planner, Chop, etc to Mantid.


Keywords: SSC,2014,All

@NickDraper
Copy link
Contributor Author

@NickDraper (2014-12-03T11:29:41):
Move all SSC tickets to critical by default


@peterfpeterson (2014-12-10T15:11:25):
http://trac.mantidproject.org/mantid/ticket/10611 is part of this.


@NickDraper (2015-03-04T11:22:33):
Modified to be specific for Chop funcationality, Horace planner functionality added in ticket http://trac.mantidproject.org/mantid/ticket/10940


@NickDraper (2015-03-10T15:49:01):
Batch modify all SSC tickets to critical priority (this will also show up as an update for all those already as critical)


@AndreiSavici (2015-04-08T18:16:41):
Moved it to the next iteration. Need more information about the requirements

@NickDraper NickDraper added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Direct Inelastic Issues and pull requests related to direct inelastic SSC labels Jun 3, 2015
@NickDraper NickDraper added this to the Release 3.5 milestone Jun 3, 2015
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@NickDraper NickDraper modified the milestone: Release 3.6 Jan 22, 2016
@mducle
Copy link
Member

mducle commented Jul 5, 2016

@NickDraper @AndreiSavici @stuartcampbell

Do you mind if I work on this and replace the current PyChop? Russell Ewings has benchmarked and fixed bugs and generally improved the Chop scripts, and put his things on the user script repository, but there's no GUI. In addition the current chop calculations for LET relies on lookup tables calculated in McStas for an old configuration of the choppers which LET no longer uses. Instead, David Voneshen has a script that calculates the elastic resolution from the chopper opening times which would be good to have to replace the current LET script.

Finally, I'd like to make an improve command-line interface to be able to use Chop to calculate the linewidths for fitting crystal fields ( re #15684 ). So, my intention is to replace the current PyChop with the updates from Russell and David and to revamp the GUI, and add a CLI.

However, the current scripts only really cover ISIS instruments - I presume that "Garrett's Python Scripts" (e.g. #7737 or #8442 ) cover SNS instruments? I can't seem to find any sign of these scripts on the web though... Do you know of any SNS chop equivalents?

@NickDraper
Copy link
Contributor Author

Duc,

We would be more than happy for you to work on this. As far as I know @AndreiSavici is not currently working on this, although he can correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Direct Inelastic Issues and pull requests related to direct inelastic High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

No branches or pull requests

4 participants