Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopyInstrumentParameters performance & efficiency #10207

Closed
1 task done
abuts opened this issue Apr 23, 2014 · 1 comment
Closed
1 task done

CopyInstrumentParameters performance & efficiency #10207

abuts opened this issue Apr 23, 2014 · 1 comment
Assignees
@abuts
Labels
Framework Issues and pull requests related to components in the Framework
Milestone
Release 3.2

Comments

@abuts
Copy link
Member

abuts commented Apr 23, 2014

This ticket is blocked by :

This is actually continuation of the ticket http://trac.mantidproject.org/mantid/ticket/9082

The fix provided in http://trac.mantidproject.org/mantid/ticket/9082 should work but

  1. instrument parameters values are copied as strings when shared pointer to the parameter is available.

  2. Parameter map is copied& reallocated twice when new map is there.

  3. Algorithm performance test.

  4. Merging the parameter map option? (it may be another ticket)

To complete the http://trac.mantidproject.org/mantid/ticket/9082 properly, at least 1-3 should be fixed.
@abuts
Copy link
Member Author

abuts commented Jun 3, 2015

This issue was originally trac ticket 9364

@abuts abuts added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@abuts abuts self-assigned this Jun 3, 2015
@abuts abuts added this to the Release 3.2 milestone Jun 3, 2015
@abuts abuts closed this as completed Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuts abuts

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
1 participant
@abuts