Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with spaces in <locations> #10249

Closed
Anders-Markvardsen opened this issue May 2, 2014 · 2 comments
Closed

issue with spaces in <locations> #10249

Anders-Markvardsen opened this issue May 2, 2014 · 2 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone

Comments

@Anders-Markvardsen
Copy link
Member

This ticket is blocks : TRAC9427

Reported by Peter Willendrup

Loading the attached IDF gives the error

Error in execution of algorithm LoadInstrument:
bad lexical cast: source type value could not be interpreted as target
Error in execution of algorithm LoadEmptyInstrument:
bad lexical cast: source type value could not be interpreted as target

This IDF previously worked with release mantid-3.1.20140321.1714

Preliminary investigation indicate that this due to now parser can't handle spaces in <locations> attribute values.

Fix this and also give more meaningful error message if attribute values of <locations> are not valid

It was found by substituting

<component type="MonNDtype-0" name="nD_Mantid_0" idlist="MonNDtype-0-list">
<locations x=" 0.285491" y="-1.5" y-end="1.5" n-elements=" 300" z=" 48.019" rot="61.6534107436081" axis-x="0" axis-y="1" axis-z="0" />
</component>

<type name="MonNDtype-0">
<component type="pixel-0">
<locations r=" 3.99948" t=" -73.3674" t-end=" 73.3676" n-elements=" 100"/>
</component>

</type>

With

<component type="MonNDtype-0" name="nD_Mantid_0" idlist="MonNDtype-0-list">
<locations x="0.285491" y="-1.5" y-end="1.5" n-elements="300" z="48.019" rot="61.6534107436081" axis-x="0" axis-y="1" axis-z="0" />
</component>

<type name="MonNDtype-0">
<component type="pixel-0">
<locations r="3.99948" t="-73.3674" t-end="73.3676" n-elements="100"/>
</component>

</type>

and idf was found to load

@Anders-Markvardsen Anders-Markvardsen added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@Anders-Markvardsen Anders-Markvardsen self-assigned this Jun 3, 2015
@Anders-Markvardsen Anders-Markvardsen added this to the Release 3.2 milestone Jun 3, 2015
@Anders-Markvardsen
Copy link
Member Author

This issue was originally trac ticket 9406

@Anders-Markvardsen
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

No branches or pull requests

1 participant