Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PropertyHistory performance #10252

Closed
1 task done
mantid-builder opened this issue May 2, 2014 · 2 comments
Closed
1 task done

Improve PropertyHistory performance #10252

mantid-builder opened this issue May 2, 2014 · 2 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@mantid-builder
Copy link
Collaborator

This issue was originally TRAC 9409

Original Reporter: Samuel Jackson

This ticket is blocked by :

PropertyHistory can give very slow performance as it has to convert properties to a string representation. For example, the CreateWorkspace algorithm will convert the vectors passed to it to a string (which also gets saved in the Nexus file). We need to find a way to improve the performance.

@mantid-builder
Copy link
Collaborator Author

@OwenArnold (2014-05-02T14:04:07):
Can you specify some more about the problem? Does this relate to code that has/is about to go into master? If the code that is causing bad performance has not yet made it to master, would be better not to allow it to if a problem has already been identified. What is currently affected by the poor performance?


@OwenArnold (2014-05-02T14:04:34):
Can you specify some more about the problem? Does this relate to code that has/is about to go into master? If the code that is causing bad performance has not yet made it to master, would be better not to allow it to if a problem has already been identified. What is currently affected by the poor performance?


Samuel Jackson (2014-05-02T15:12:43):
This is partly related to the changes to algorithm history in that it could make the performance worse as we're able to record more information about child algorithms. However, the unit/performance test results are largely unchanged by the new implementation.

This issue already existed in Mantid but may be compounded by the history changes. For example, the CreateWorkspace algorithm can take a long time to create its history record as it potentially has to convert large vectors of numbers to strings which are stored in PropertyHistory. So in the new implementation if we have a DataProcessorAlgorithm with lots of child CreateWorkspace calls it will increase execution time of that workflow.

In short, we don't have bad performance yet, but there are situations which could cause bad performance if left un-tackled. As nested history is not the cause of this problem I thought it could possibly be split into a separate ticket.


Samuel Jackson (2014-06-13T15:54:58):
Won't have time to do this for this release. Move to Release 3.3.


@NickDraper (2015-04-27T08:10:34):
Moved to R3.5 at the R3.4 code freeze

@mantid-builder mantid-builder added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.5 milestone Jun 3, 2015
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@NickDraper NickDraper modified the milestone: Release 3.6 Jan 22, 2016
@NickDraper
Copy link
Contributor

This has not proved a problem since

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

2 participants