Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterClusterFaces enhancements #10298

Closed
1 task done
OwenArnold opened this issue May 14, 2014 · 1 comment
Closed
1 task done

FilterClusterFaces enhancements #10298

OwenArnold opened this issue May 14, 2014 · 1 comment
Assignees
Labels
Diffraction Issues and pull requests related to diffraction
Milestone

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocked by :

  • TRAC9428
  • If FilteringWorkspace is provided, then output an additional column with the radius of the face from the peak centre. This will allow client code to determine an effective radius of each cluster
  • Check that the MDHistoWorkspace provided actually contains labels ids rather than being a generic MDHistoWorkspace. I think the algorithm would probably badly misbehave if the latter case was currently provided. To check. For each signal value perform signal_value%1 == 0.
  • Parallelise the algorithm according to the criteria already defined in the algorithm comments. As an intermediate data structure, TableWorkspaces themselves may work best.
  • Add the ability to limit the number of output rows, and report that truncation has occurred in that eventuality.
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 9455

@OwenArnold OwenArnold added the Diffraction Issues and pull requests related to diffraction label Jun 3, 2015
@OwenArnold OwenArnold self-assigned this Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.2 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
Development

No branches or pull requests

1 participant