Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New MVP Reflectometry GUI - Expand Table format for new fields #10316

Closed
1 task done
mantid-builder opened this issue May 15, 2014 · 1 comment
Closed
1 task done

New MVP Reflectometry GUI - Expand Table format for new fields #10316

mantid-builder opened this issue May 15, 2014 · 1 comment
Assignees
Labels
Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Keith Brown

This ticket is blocked by :

This ticket is blocks : TRAC9368, TRAC10301

there's a new field "options" that needs added and it's contents plugged into the params property of ReflectometryReductionOneAuto

The interface needs to be expanded to support this. The options column should come after the groups column.

The overrides should be expressed as key-value pairs. The key value paris should reflect the options in ReflectometryReductionOneAuto. It would be best to dynamically populate the allowed keys list based on the available ReflectometryReductionOneAuto property names, for example:

StartOverlap=0.1, EndOverlap=0.2

. '''Ensure we have unit tests to thoroughly verify this new behaviour''' We don't want to fully run the algorithm for each scenario, this would take too long, but we do need unit tests to ensure that Options are always set on the algorithm post init() and prior to execute(). The last thing we want is users complaining about some obscure scenario, where they can't overload options, I suggest introducing a new class for this, which would make the behaviour testable, and could be used within the presenter.

@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 9473

@mantid-builder mantid-builder added the Reflectometry Issues and pull requests related to reflectometry label Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.3 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

No branches or pull requests

2 participants