Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Single Mode to Call Batch Mode or Vice-Versa #10328

Closed
PeterParker opened this issue May 19, 2014 · 1 comment
Closed

Refactor Single Mode to Call Batch Mode or Vice-Versa #10328

PeterParker opened this issue May 19, 2014 · 1 comment
Assignees
@AntonPiccardoSelg
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period. SANS Issues and pull requests related to SANS
Milestone
Release 3.7

Comments

@PeterParker
Copy link
Contributor

sans_code
This issue was originally TRAC 9485

Currently, there is some duplication (and subtle differences) with how we perform the ISIS SANS reduction in "Single Mode" and "Batch Mode". We should factor out common code and have either:

  1. Batch Mode written completely in terms of Single Mode, i.e. running the Single Mode reduction multiple times; or,
  2. Single Modewritten completely in terms of Batch Mode, i.e. running the Batch Mode reduction but just feeding it a single entry.

I think we'd get the most benefit (having the two modes be as similar as possible) with option 2.

Keywords: Maintenance
@PeterParker PeterParker added SANS Issues and pull requests related to SANS Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@PeterParker PeterParker self-assigned this Jun 3, 2015
@NickDraper
Copy link
Contributor

To be considered during the SANS refactoring #15876 note added, close this issue

@NickDraper NickDraper added this to the Release 3.7 milestone Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonPiccardoSelg AntonPiccardoSelg

Labels
Maintenance Unassigned issues to be addressed in the next maintenance period. SANS Issues and pull requests related to SANS
Projects
None yet
Milestone
Release 3.7
Development

No branches or pull requests
3 participants
@NickDraper @PeterParker @AntonPiccardoSelg