Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend algorithm LoadInstrumentFromNexus #10380

Closed
1 task done
peterfpeterson opened this issue May 28, 2014 · 2 comments
Closed
1 task done

Extend algorithm LoadInstrumentFromNexus #10380

peterfpeterson opened this issue May 28, 2014 · 2 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@peterfpeterson
Copy link
Member

This issue was originally TRAC 9537

This ticket is blocked by :

The current algorithm LoadInstrumentFromNexus has very limited functionality. It loads only muon Nexus files and gets only a small amount of information from it.

It can extended by taking code from algorithms that load instruments from nexus files (LoadEventNexus, CreateGroupingWorkspace, and CreateChunkingFromInstrument in http://trac.mantidproject.org/mantid/ticket/9511 are three). Each of them has very similar code that should be collected into a single workflow algorithm.

@peterfpeterson
Copy link
Member Author

@KarlPalmen (2014-07-24T15:12:43):
A look at the code shows:

'''CreateChinkingFromInstrument''' first attempts to get the instrument from the workspace. If there is no workspace, it runs loadIDFFromNexus and it also reads the instrument name from Nexus separately. If it does not run LoadInstrument in the event of loadIDFFromNexus not working.

'''CreateGroupingWorkspace''' first attempts to get the instrument from the workspace. If there is no workspace, it runs LoadInstrument with either the instrument name or IDF filename. It has no nexus file.

'''LoadEventNexus''' first attempts to LoadIDFFromNexus. If that does not work, it reads the Nexus file to get the instrument name then runs LoadInstrument with the instrument name.


@KarlPalmen (2014-08-04T10:25:23):
LoadInstrumentFromNexus currently has no unit test. A unit test would be added in the course of work on this ticket.

@peterfpeterson peterfpeterson added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@peterfpeterson peterfpeterson self-assigned this Jun 3, 2015
@peterfpeterson
Copy link
Member Author

This has been done for some time already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

1 participant