Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace calls to quick() in old reflectometry gui #10409

Closed
OwenArnold opened this issue Jun 3, 2014 · 1 comment
Closed

Replace calls to quick() in old reflectometry gui #10409

OwenArnold opened this issue Jun 3, 2014 · 1 comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@OwenArnold
Copy link
Contributor

Max wants us to use '''ReflectometryReductionAuto''' in the reflectometry gui rather than '''quick'''.

As a guide. He has said that the following works for him

#!python
wq,wlam,th=ReflectometryReductionOne(InputWorkspace=loadedRun,I0MonitorIndex='2',ProcessingInstructions='3',WavelengthMin='1.5',WavelengthMax='15',WavelengthStep='0.01',MonitorBackgroundWavelengthMin='15',MonitorBackgroundWavelengthMax='17',MonitorIntegrationWavelengthMin='4',MonitorIntegrationWavelengthMax='10',OutputWorkspace=runno+'_IvsQ',OutputWorkspaceWavelength=runno+'IvsLam',FirstTransmissionRun=transrun,Params='1.5,0.01,15',StartOverlap='10',EndOverlap='12')

But we should absolutely minimise the number of hard-coded values. '''ReflectometryReductionOneAuto''' will automatically pick many of these up. I think of the above, only StartOverlap and EndOverlap would need to be hardcoded.

  • Add an option in the old gui, called 'Use Reflectometry Algorithm'. Default this to False.
  • Use the option as part of a conditional statement. If False, run the old style Quick. If True run ReflectometryReductionOneAuto.

The reason for defaulting to the old reduction is that the Polarisation Correction routines have not yet been added to ReflectometryReductionOne.

@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 9566

@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry labels Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.2 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

No branches or pull requests

1 participant