Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up reflectometry algorithms #10479

Closed
mdoucet opened this issue Jun 11, 2014 · 1 comment
Closed

Clean up reflectometry algorithms #10479

mdoucet opened this issue Jun 11, 2014 · 1 comment
Assignees
Labels
Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@mdoucet
Copy link
Member

mdoucet commented Jun 11, 2014

This issue was originally TRAC 9636

Since the reduction situation with REFL and REFM has evolved at SNS, it's not clear which reflectometry algorithm is actually used.

Someone needs to go through the following algorithms and decide whether they need to be removed:

  1. RefLReduction.py (this is the main REFL reduction algorithm, but it hasn't been touched for 8 months. Is it still in use?)
  2. RefReduction.cpp (removing this will also mean removing REFM from the reduction UI - an easy task)
  3. RefRoi.cpp (this algorithm is called by RefReduction)
  4. REFLReprocess.py (this algorithm was written to quickly re-reduce data files that have already been reduced. If that's not something that's used, this algorithm should probably go.)

If those algorithms are kept, they should be properly documented with an RST file and given usage examples as necessary.

There is help on how to document the algorithms in the following links: http://www.mantidproject.org/Algorithm_Documentation http://www.mantidproject.org/Algorithm_Usage_Examples And there are examples implemented for Fit, Load, LoadISISNexus and Rebin.

@mdoucet
Copy link
Member Author

mdoucet commented Apr 27, 2015

@NickDraper (2015-04-27T08:10:34):
Moved to R3.5 at the R3.4 code freeze

@mdoucet mdoucet added the Reflectometry Issues and pull requests related to reflectometry label Jun 3, 2015
@mdoucet mdoucet added this to the Release 3.5 milestone Jun 3, 2015
@mdoucet mdoucet closed this as completed Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

No branches or pull requests

2 participants