Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up documentation for IntegratePeaksHybrid #10504

Closed
mantid-builder opened this issue Jun 16, 2014 · 1 comment
Closed

Tidy up documentation for IntegratePeaksHybrid #10504

mantid-builder opened this issue Jun 16, 2014 · 1 comment
Assignees
@OwenArnold
Labels
Diffraction Issues and pull requests related to diffraction
Milestone
Release 3.2

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Samuel Jackson

Low priority maintenance task from http://trac.mantidproject.org/mantid/ticket/9509. There are two issues:

  • IntegratePeaksHybrid doesn't have an rst file or usage examples.
  • ConnectedComponentLabelingTest.h has what looks like a merge conflict with the comment on line 151 which should be removed.
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 9661

@mantid-builder mantid-builder added the Diffraction Issues and pull requests related to diffraction label Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.2 milestone Jun 3, 2015
MichaelWedel pushed a commit that referenced this issue Nov 26, 2015
Refs #10504. SpaceGroupFactory now generates prototypes on demand.
4c21f89
MichaelWedel pushed a commit that referenced this issue Nov 26, 2015
Refs #10504. Extracted prototype generation into method
5f8e2a4
MichaelWedel pushed a commit that referenced this issue Nov 26, 2015
Refs #10504. Added AbstractSpaceGroupGenerator and two sub-classes
49b71ee 
This will replace a lot of code in SpaceGroupFactory eventually.
MichaelWedel pushed a commit that referenced this issue Nov 26, 2015
Refs #10504. SpaceGroupFactory now uses AbstractSpaceGroupGenerator
9cdfac7 
The factory now uses AbstractSpaceGroupGenerator-objects to delay prototype construction until it's really needed. Separating the generation out of the factory itself makes it more flexible (other space group generation algorithm) and more focused (factory does not care anymore how prototypes are constructed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OwenArnold OwenArnold

Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
2 participants
@OwenArnold @mantid-builder