Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Kernel::Interpolation to correctly handle multiple loading from string #10524

Closed
MichaelWedel opened this issue Jun 18, 2014 · 1 comment
Assignees
Labels
Framework Issues and pull requests related to components in the Framework
Milestone

Comments

@MichaelWedel
Copy link
Contributor

When an instrument definition contains a FitParameter with a lookup-table, all values are inserted into the table twice (in some situations even 4 times).

I have traced this down to LoadInstrument::exec():

174      // populate parameter map of workspace 
175      m_workspace->populateInstrumentParameters();
176
177      // check if default parameter file is also present, unless loading from
178      if (!m_filename.empty())
179        runLoadParameterFile();

Both line 175 and 179 execute the >> operator for Interpolation (eventually), on the same instance, so the data stored in the IDF are added twice.

Adding a clearData() method to Interpolation and calling that inside the operator fixes the problem, but maybe it's possible to track down the real origin of this behavior.

If anyone knows details of this loading procedure, I would be happy about advice.

@MichaelWedel
Copy link
Contributor Author

This issue was originally trac ticket 9682

@MichaelWedel MichaelWedel added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@MichaelWedel MichaelWedel self-assigned this Jun 3, 2015
@MichaelWedel MichaelWedel added this to the Release 3.3 milestone Jun 3, 2015
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
... instead of creating new ones from the position. Seems like
generating new ones is wildly inaccuarate.
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
…arizationcorrection

Refs #9840

This merge is to incorporate the changes from #10524 into #9840.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

1 participant