Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WorkspaceFactory to use the MemoryManager #1054

Closed
NickDraper opened this issue Aug 13, 2008 · 1 comment
Closed

Update WorkspaceFactory to use the MemoryManager #1054

NickDraper opened this issue Aug 13, 2008 · 1 comment
Assignees
Milestone

Comments

@NickDraper
Copy link
Contributor

Currently the Workspace Manager uses the requested size of a workspace to decide wether to create a ManagedWorkspace or not. This is done by comparing HistogramCount*TimeBins to a value in the .properties file.

This should be updated to use the information that can be provided by the MemoryManager. I suggest that we change it so it reads a value from the .properties file that gives a percentage of the available memory that may be used for the workspace. Therefore if they have the value set to 50% then if a full workspace would take less than 50% of the available memory then that would be returned, otherwise a managed workspace would be used.

You will need to do a bit of benchmarking to investigate what a sensible default value should be.

@NickDraper
Copy link
Contributor Author

This issue was originally trac ticket 206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants