Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Y-Axis Units in ISIS SANS Reduction and Load/SaveCanSAS #10629

Closed
PeterParker opened this issue Jul 1, 2014 · 1 comment
Closed

Improve Y-Axis Units in ISIS SANS Reduction and Load/SaveCanSAS #10629

PeterParker opened this issue Jul 1, 2014 · 1 comment
Assignees
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS

Comments

@PeterParker
Copy link
Contributor

sans_feature
This issue was originally TRAC 9787

http://trac.mantidproject.org/mantid/ticket/9710, http://trac.mantidproject.org/mantid/ticket/9721 and http://trac.mantidproject.org/mantid/ticket/9772 were all "band-aid" fixes, trying to get correct unit labels for the y-axis of ISIS SANS-reduced workspaces for the purposes of plotting, as well as writing out to CanSAS data files which are then loaded into SasView.

There are some problems that need to be addressed:

  • SaveCanSAS looks for YUnitLabels of "I(q) (cm-1)" and writes out I and Idev units of "1/cm", else it writes out whatever the YUnitLabel is. Since the CanSAS format is strict about [http://www.cansas.org/formats/canSAS1d/1.1/doc/element_SASdata.html#idata which units can be used], we need to get a better handle on what other units SaveCanSAS should be able to write out (if any), and what the YUnitLabels of the workspaces being written have to be in those cases. Should we disallow workspaces with YUnitLabels we don't recognise, or should we default to some sensible unit and output a warning?
  • LoadCanSAS does not (and has never) read in y-axis unit labels, meaning YUnitLabels on plots do not survive the roundtrip of Save/LoadCanSAS.

The algorithm documentation should be updated accordingly.

@PeterParker PeterParker added the SANS Issues and pull requests related to SANS label Jun 3, 2015
@PeterParker PeterParker self-assigned this Jun 3, 2015
@gemmaguest gemmaguest added the ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS label Aug 29, 2019
@gemmaguest
Copy link
Member

Closing as users are being recommended to use Load/SaveNXCanSAS instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Projects
None yet
Development

No branches or pull requests

4 participants