Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Unmasking By Time Channel for Specific Parts of Detector Bank #10676

Closed
PeterParker opened this issue Jul 7, 2014 · 4 comments
Closed
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reported By User Issues that were found or highlighted by a user/scientist SANS Issues and pull requests related to SANS Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@PeterParker
Copy link
Contributor

sans_feature
This issue was originally TRAC 9834

Currently we can mask by time channel, but the mask is applied to the entire detector bank. Richard has asked for a way to only mask certain parts of the bank.

It is not clear how well Q1D is currently set up to accommodate a change like this.

@PeterParker PeterParker added the SANS Issues and pull requests related to SANS label Jun 3, 2015
@PeterParker PeterParker self-assigned this Jun 3, 2015
@AntonPiccardoSelg
Copy link
Contributor

We don't have time masking on a per detector basis in Mantid as far as I am aware.

@gemmaguest gemmaguest added the ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS label Aug 29, 2019
@RichardHeenan
Copy link

At present if we see say Bragg spikes we play safe and take out those time bins over the whole detector (all detector banks ? - CHECK) , which is often over kill.

(If it is all banks, then we ought to have time masking on specific banks only.)

However to time mask in specific regions would make the setting up of a mask and Q1D etc much more complicated, and probably not worth the effort or the slow down in reduction.

@gemmaguest gemmaguest added the Reported By User Issues that were found or highlighted by a user/scientist label Jul 29, 2020
@stale
Copy link

stale bot commented Feb 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 22, 2021
@stale
Copy link

stale bot commented Mar 1, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reported By User Issues that were found or highlighted by a user/scientist SANS Issues and pull requests related to SANS Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
Status: Stale
Development

No branches or pull requests

5 participants