Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve Default Beam Centre Finder Radius Limits from Instrument Param Files #10712

Closed
PeterParker opened this issue Jul 11, 2014 · 2 comments
Closed

Retrieve Default Beam Centre Finder Radius Limits from Instrument Param Files #10712

PeterParker opened this issue Jul 11, 2014 · 2 comments
Assignees
@Matthew-Andrew
Labels
SANS Issues and pull requests related to SANS
Milestone
Release 3.13

Comments

@PeterParker
Copy link
Contributor

sans_feature
This issue was originally TRAC 9870

Steve King has pointed out that each of the SANS instruments use different radius limits for the Beam Centre Finder in the interface. Currently this has to be changed every single time it's used.

Instead, let's have sensible defaults on a per instrument (and also per detector) basis that are read in from Instrument Parameter files.

Steve's manual on using the Beam Centre Finder:

http://www.mantidproject.org/Using_the_SANS_GUI_Beam_Centre_Finder
@PeterParker PeterParker added the SANS Issues and pull requests related to SANS label Jun 3, 2015
@PeterParker PeterParker self-assigned this Jun 3, 2015
peterfpeterson added a commit that referenced this issue Nov 26, 2015
@peterfpeterson
Re #10712. Added method to calculate md5 from a string.
1986b57
NickDraper added a commit that referenced this issue Nov 26, 2015
@NickDraper
re #10712 Corrected whole file formatting, as partial format look bad
6866b24
@AntonPiccardoSelg
Copy link
Contributor

AntonPiccardoSelg commented Oct 5, 2017 •
edited

That seems like a good idea. Talk to the scientists what these values should be and add them with a sensible name to the IPF

@Matthew-Andrew Matthew-Andrew added this to the Release 3.12 milestone Oct 30, 2017
@NickDraper NickDraper modified the milestones: Release 3.12, Release 3.13 Feb 27, 2018
Matthew-Andrew pushed a commit that referenced this issue May 9, 2018
Re #10712 Added component choice to beam centre finder
6228d9c
Matthew-Andrew pushed a commit that referenced this issue May 16, 2018
Re #10712 started adding tests
c1c08fe
Matthew-Andrew pushed a commit that referenced this issue May 23, 2018
Re #10712 Added unit tests
7fddd47
Matthew-Andrew pushed a commit that referenced this issue May 23, 2018
Re #10712 Updated unit tests
036e3a8
Matthew-Andrew pushed a commit that referenced this issue May 24, 2018
Re #10712 Updated release notes
1131880
@Matthew-Andrew Matthew-Andrew mentioned this issue May 24, 2018
Merged
7 tasks
Matthew-Andrew pushed a commit that referenced this issue Jun 1, 2018
Updat run_tab_presenter_test call count Re #10712
8fe77ed
@Matthew-Andrew
Copy link
Contributor

This was resolved in #22416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matthew-Andrew Matthew-Andrew

Labels
SANS Issues and pull requests related to SANS
Projects
None yet
Milestone
Release 3.13
Development

No branches or pull requests
4 participants
@NickDraper @PeterParker @AntonPiccardoSelg @Matthew-Andrew