Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ConvertUnits to take detector table #10722

Closed
1 task
peterfpeterson opened this issue Jul 11, 2014 · 2 comments
Closed
1 task

Modify ConvertUnits to take detector table #10722

peterfpeterson opened this issue Jul 11, 2014 · 2 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@peterfpeterson
Copy link
Member

This issue was originally TRAC 9880

This ticket is blocked by :

Add an optional workspace with a detector table which will be used rather than the instrument geometry. The table is changing according to http://trac.mantidproject.org/mantid/ticket/9879.

@peterfpeterson
Copy link
Member Author

@stuartcampbell (2014-08-23T01:05:05):
Added optional property for detector pars.

Just added declaration in init() method to pass
in a TableWorkspace containing detector parameters.

refs http://trac.mantidproject.org/mantid/ticket/9880

264f303


@stuartcampbell (2014-08-23T01:05:06):
Added initial stub of test for using detector pars.

refs http://trac.mantidproject.org/mantid/ticket/9880

8584164


@stuartcampbell (2014-08-29T20:41:41):
Started to add logic to use detector pars from table.

refs http://trac.mantidproject.org/mantid/ticket/9880

e174dac


@stuartcampbell (2014-09-15T19:09:36):
Added logic to check for L1.

Added code to see if an L1 column is there in
the detector pars workspace.
Added unit test for with/without L1
refs http://trac.mantidproject.org/mantid/ticket/9880

654aa32


@stuartcampbell (2014-09-25T06:06:33):
Initial working version that can use parameter workspace.

refs http://trac.mantidproject.org/mantid/ticket/9880

10ebdc6


@stuartcampbell (2014-09-25T06:06:34):
Added simple unit test for parameter workspace.

refs http://trac.mantidproject.org/mantid/ticket/9880

f4b627d


@stuartcampbell (2014-09-26T00:45:21):
Remove redefining variable. refs http://trac.mantidproject.org/mantid/ticket/9880

1eb9f95


@stuartcampbell (2014-09-26T01:10:49):
Just disabling new test to make sure its not causing problems.

refs http://trac.mantidproject.org/mantid/ticket/9880

cf60838


@NickDraper (2014-12-08T10:25:35):
Moved to the backlog at the code freeze of R3.3


@stuartcampbell (2014-12-10T13:20:50):
As this is causing some subtle problems with the current usage of ConvertUnits - which could be due to these changes or just the way a couple of tests are written.

But to be safe, I am going to create a new algorithm ConvertUnitsUsingDetectorTable() under ticket http://trac.mantidproject.org/mantid/ticket/10748.

@peterfpeterson peterfpeterson added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@stuartcampbell
Copy link
Collaborator

Closing this now as we are just going to use a separate algorithm for now and probably need to look more seriously at ConvertUnits() in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

2 participants