Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow Unit Tests for Sam Jackson #10746

Closed
OwenArnold opened this issue Jul 15, 2014 · 1 comment
Closed

Slow Unit Tests for Sam Jackson #10746

OwenArnold opened this issue Jul 15, 2014 · 1 comment
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocks : TRAC9905

We have a number of slow running unit tests which we need to fix as part of the 3.3 maintenance window. We are targeting test suits than execute in > 2 seconds on our clean rhel6 build servers.
For IO tests (Loading & Saving) we have applied a more generous threshold of > 5 seconds.

See the full list to see which tests have been assigned to you:
http://www.mantidproject.org/images/2/2f/Slow_tests.xlsx_-_Sheet1.pdf

== Criteria ==

  1. Test suits (each test class instance) '''should execute in < 1 second''' as a rough target
  2. As a corollary to the above, If the test suite contains lots of test methods aim for '''< 0.1 second per test method'''
  3. If for some reason you get the speed up the test below the target using the strategies listed below, you need to justify why when you close the ticket.

== Guidelines/instructions to help ==

  1. '''Keep tests readable and improve code readability where possible. Unit tests are documentation.'''

  2. Do not delete test methods without good reason. We do not want to reduce test coverage

  3. Changing the algorithm code to improve speed is OK, but exercise caution. Add additional test coverage if it's not already good enough.

  4. Take test methods that are slow and involve IO, or are processor intensive and make them into system tests. Integration tests are not Unit tests.

  5. Most of the speed improvements will probably come from better selection of input data. Caching input data is also a good option.

  6. Create sub tickets for algorithms or groups of algorithms to help testability if you wish, but mark this ticket as the 'blocked' by each one.

    Keywords: Maintenance

@OwenArnold OwenArnold added Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 9904

@OwenArnold OwenArnold added this to the Release 3.3 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

No branches or pull requests

1 participant