Merge in Tube Calibration Changes from Richard

[PeterParker]

sans_feature
This issue was originally TRAC 10050

At some point we need to merge in Richard's changes to the Tube Calibration code. This will get to be a bigger and bigger issue the longer we leave it.

[PeterParker]

@NickDraper (2014-12-08T10:25:36):
Moved to the backlog at the code freeze of R3.3

---

@PeterParker (2015-05-26T13:11:54):
Anton:

There is a slide about this (with a "before" and "after" screenshot) in the intro slides we went through during the handover.

Basically, we need to get the latest version of the script(s) used by Richard to calibrate the SANS2D detector tubes and get that in Git. These scripts also require some modifications to Karl's underlying tube calibration code.

It may take some work to integrate Richard's changes without breaking existing tests (if there are any) and existing functionality. I would advise caution here, since changes to this code obviously could have far-reaching consequences outside of ISIS SANS.

[AntonPiccardoSelg]

Hmm, I have been unaware of this. @Mantid-Matthew Please speak to Richard about this.

[Matthew-Andrew]

Tube calibration code is separate to Mantid and used to generate calibration files. Need to check with current scientists where these scripts are currently stored.

[gemmaguest]

Check with Richard what, if anything, needs doing

[RichardHeenan]

I think this still needs some work.
There were a handful of changes to the underlying shared py code (e.g. it only worked for vertical tubes, not the horizontal ones on SANS2d), but then there were recently some py3 issues.

[smk78]

This is important, but will be much more effort than integrating the Direct Beam iterating script.
Also see #27386

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

[stale]

This issue has been automatically marked as stale because it has not had activity in 6 months. It will be closed in 7 days if no further activity occurs.
Allowing issues to close as stale helps us filter out issues which can wait for future development time. All issues closed by stale bot act like normal issues; they can be searched for, commented on or reopened at any point.
If you'd like a closed stale issue to be considered, feel free to either re-open the issue directly or contact a developer.
To extend the lifetime of an issue please comment below, it helps us see that this is still affecting you and you want it fixed in the near-future. Extending the lifetime of an issue may cause the development team to prioritise it over other issues, which may be closed as stale instead.

[stale]

This issue has been closed automatically. If this still affects you please re-open this issue with a comment or contact us so we can look into resolving it.

[gemmaguest]

Closing this in favour of #27386 because I think we only need to worry about the latest versions of the scripts