Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate workspace validators into individual implementation files #11035

Closed
martyngigg opened this issue Aug 29, 2014 · 1 comment
Closed

Separate workspace validators into individual implementation files #11035

martyngigg opened this issue Aug 29, 2014 · 1 comment
Assignees
@mantid-roman
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone
Release 3.6

Comments

@martyngigg
Copy link
Member

This issue was originally TRAC 10193

... and add separate unit tests for them in API.

The WorkspaceValidators are all currently implemented in the same header
file, API/inc/MantidAPI/WorkspaceValidators.h, with the tests all in a single unit test file in DataObjects!

We should separate them out like all other classes into single implementation headers and source files + tests in the API layer using the WorkspaceTester class in MantidTestHelpers/FakeObjects.h instead of a "real" workspace type.

Keywords: Maintenance
@martyngigg
Copy link
Member Author

@NickDraper (2015-04-27T08:10:35):
Moved to R3.5 at the R3.4 code freeze

@martyngigg martyngigg added Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@martyngigg martyngigg added this to the Release 3.5 milestone Jun 3, 2015
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@mantid-roman mantid-roman self-assigned this Oct 2, 2015
mantid-roman added a commit that referenced this issue Oct 12, 2015
@mantid-roman
Re #11035. Split workspace validators into files.
651af50
mantid-roman added a commit that referenced this issue Oct 12, 2015
@mantid-roman
Re #11035. Fixed includes in Algorithms.
a3c4e68
mantid-roman added a commit that referenced this issue Oct 12, 2015
@mantid-roman
Merge remote-tracking branch 'origin/master' into 11035_separate_work…
d13d08e 
…space_validators

Conflicts:
	Framework/Algorithms/src/CopyInstrumentParameters.cpp
	Framework/Algorithms/src/CropWorkspace.cpp
	Framework/Algorithms/src/DiffractionEventCalibrateDetectors.cpp
	Framework/Algorithms/src/FindCenterOfMassPosition.cpp
	Framework/Algorithms/src/FindCenterOfMassPosition2.cpp
	Framework/Algorithms/src/GetDetOffsetsMultiPeaks.cpp
	Framework/Algorithms/src/GetDetectorOffsets.cpp
	Framework/Algorithms/src/MaskDetectorsIf.cpp
	Framework/Algorithms/src/NormaliseToMonitor.cpp
	Framework/Algorithms/src/Q1DWeighted.cpp
	Framework/Algorithms/src/SANSDirectBeamScaling.cpp
	Framework/Algorithms/src/SolidAngle.cpp
Re #11035
mantid-roman added a commit that referenced this issue Oct 12, 2015
@mantid-roman
Re #11035. Fix includes in CurveFitting.
bd71568
mantid-roman added a commit that referenced this issue Oct 12, 2015
@mantid-roman
Re #11035. Fix includes in DataHandling.
fe577cf
mantid-roman added a commit that referenced this issue Oct 12, 2015
@mantid-roman
Re #11035. Fix includes in Crystal.
97c7a6d
mantid-roman added a commit that referenced this issue Oct 12, 2015
@mantid-roman
Re #11035. Fix includes in MDAlgorithms.
800b9ac
mantid-roman added a commit that referenced this issue Oct 12, 2015
@mantid-roman
Re #11035. Fix includes in WorkflowAlgorithms.
4ecc09d
mantid-roman added a commit that referenced this issue Oct 14, 2015
@mantid-roman
Re #11035. Added the API tests.
07699c3
mantid-roman added a commit that referenced this issue Oct 14, 2015
@mantid-roman
Re #11035. Fixed test in DataObjects.
82b0a44
@mantid-roman mantid-roman mentioned this issue Oct 14, 2015
Merged
mantid-roman added a commit that referenced this issue Oct 14, 2015
@mantid-roman
Re #11035. Fixed python exports.
ffe2db5
mantid-roman added a commit that referenced this issue Oct 15, 2015
@mantid-roman
Re #11035. Applied clang-format corrections.
e531389
mantid-roman added a commit that referenced this issue Oct 15, 2015
@mantid-roman
Re #11035. Re-enable unit test.
23200d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mantid-roman mantid-roman

Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Milestone
Release 3.6
Development

No branches or pull requests
3 participants
@martyngigg @NickDraper @mantid-roman