Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoadSQW will fail when loading sqw file with image not aligned with lab frame #11056

Closed
abuts opened this issue Sep 8, 2014 · 2 comments
Closed

LoadSQW will fail when loading sqw file with image not aligned with lab frame #11056

abuts opened this issue Sep 8, 2014 · 2 comments
Assignees
@martyngigg
Labels
Framework Issues and pull requests related to components in the Framework
Milestone
Release 3.7

Comments

@abuts
Copy link
Member

abuts commented Sep 8, 2014

This issue was originally TRAC 10214

subj.

Currently LoadSQW will not load a sqw file with DND image not aligned according to "lab frame ?" coordinates (not sure the term is correct). The pixels (MD events) in SQW file are expressed in these coordinates.

The algorithm will formally work, but the result will be incorrect.

The purpose of the ticket is to modify load SQW to load data properly.
@abuts abuts added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@abuts abuts self-assigned this Jun 3, 2015
@abuts abuts assigned martyngigg and unassigned abuts Nov 12, 2015
@abuts
Copy link
Member Author

abuts commented Nov 12, 2015

The issue is actually a bit deeper as there are subtle differences in data loading procedure which generate MD workspaces slightly different from SQW workspaces. The differences should be rectified.

@martyngigg martyngigg added this to the Release 3.6 milestone Nov 23, 2015
@martyngigg martyngigg mentioned this issue Nov 25, 2015
Closed
@martyngigg
Copy link
Member

The way LoadSQW is currently structured is making it difficult to change what is loaded and understand how the file is layed out. My plan is therefore to create a LoadSQW v2.

martyngigg added a commit that referenced this issue Nov 26, 2015
@martyngigg
WIP Add the barebones of a reader for a binary stream.
c87e206 
Refs #11056
martyngigg added a commit that referenced this issue Dec 2, 2015
@martyngigg
WIP Add the barebones of a reader for a binary stream.
10b3d68 
Refs #11056
martyngigg added a commit that referenced this issue Dec 2, 2015
@martyngigg
WIP Added methods to a variety of types from the binary data stream.
79b4d4a 
Refs #11056
martyngigg added a commit that referenced this issue Dec 2, 2015
@martyngigg
WIP Add overloads for read arrays of values from a stream
2e052a3 
Refs #11056
martyngigg added a commit that referenced this issue Dec 2, 2015
@martyngigg
Use in-memory stream for test.
138f1b1 
Avoids any issues with the file changing in the future.
Refs #11056
martyngigg added a commit that referenced this issue Dec 3, 2015
@martyngigg
Fill in basics of documentation.
fc87be4 
Refs #11056
martyngigg added a commit that referenced this issue Dec 3, 2015
@martyngigg
WIP Implemented reading SQW header information
9acb79d 
Refs #11056
martyngigg added a commit that referenced this issue Dec 7, 2015
@martyngigg
WIP Add code to start reading SPE headers.
6527f46 
Refs #11056
martyngigg added a commit that referenced this issue Dec 7, 2015
@martyngigg
Const-qualify non-modifying members.
948317d 
Refs #11056
martyngigg added a commit that referenced this issue Dec 7, 2015
@martyngigg
WIP Add code + tests for reading spe headers.
d8c64b0 
Refs #11056
martyngigg added a commit that referenced this issue Dec 7, 2015
@martyngigg
WIP Skip the detector paramter block
df5e621 
Refs #11056
martyngigg added a commit that referenced this issue Dec 9, 2015
@martyngigg
Add methods to read 2D types from a binary file
d613c53 
The underlying can memory order be specified by an enum.
Refs #11056
martyngigg added a commit that referenced this issue Dec 9, 2015
@martyngigg
WIP Read and create SQW dimensions.
d87ac60 
Refs #11056
martyngigg added a commit that referenced this issue Dec 9, 2015
@martyngigg
WIP Read pixel data without transformations
4414354 
Refs #11056
martyngigg added a commit that referenced this issue Dec 9, 2015
@martyngigg
WIP Transform events to HKL frame.
bbe7caf 
Refs #11056
martyngigg added a commit that referenced this issue Dec 11, 2015
@martyngigg
WIP Read the pixel data in chunks
084e444 
Refs #11056
martyngigg added a commit that referenced this issue Dec 11, 2015
@martyngigg
WIP Add progress reporting.
0bf2d6b 
Refs #11056
martyngigg added a commit that referenced this issue Dec 11, 2015
@martyngigg
WIP Define LoadSQW2 as a file loader algorithm.
4cf729a 
Refs #11056
martyngigg added a commit that referenced this issue Dec 11, 2015
@martyngigg
WIP Add a metadata only flag.
bb1760c 
This loads everything but the pixel data.
Refs #11056
martyngigg added a commit that referenced this issue Dec 11, 2015
@martyngigg
WIP Add an option to make the output ws file backed.
694f376 
Refs #11056
martyngigg added a commit that referenced this issue Dec 11, 2015
@martyngigg
Add warning if the memory is insufficient to load everything.
7c9c35e 
Refs #11056
martyngigg added a commit that referenced this issue Dec 11, 2015
@martyngigg
Fix doxygen warnings
3882269 
Refs #11056
martyngigg added a commit that referenced this issue Jan 7, 2016
@martyngigg
Apply clang format patch
94f8a3d 
Refs #11056
martyngigg added a commit that referenced this issue Jan 7, 2016
@martyngigg
Set the proper MD frame for each dimension.
75e5938 
Refs #11056
martyngigg added a commit that referenced this issue Jan 7, 2016
@martyngigg
Resolve make_shared ambiguity on older boost versions.
bd9f36c 
Refs #11056
martyngigg added a commit that referenced this issue Jan 7, 2016
@martyngigg
Suppress warning in clang
970f480 
It is a bug in clang - https://llvm.org/bugs/show_bug.cgi?id=21629
Refs #11056
martyngigg added a commit that referenced this issue Jan 7, 2016
@martyngigg
Restore warning suppression on clang.
418868e 
It appears the warning happens for assignment as well as initialisation.
Refs #11056
@martyngigg martyngigg mentioned this issue Jan 7, 2016
Merged
martyngigg added a commit that referenced this issue Jan 7, 2016
@martyngigg
Update the documentation to reflect the new Q3DFrames property.
a62ecbf 
Refs #11056
martyngigg added a commit that referenced this issue Jan 15, 2016
@martyngigg
Split the boxes regularly during reading.
c172e03 
This prevents the memory requirements exploding as the number of events
pile up in the top box.
Refs #11056
martyngigg added a commit that referenced this issue Jan 15, 2016
@martyngigg
Fix bug in splitting logic.
ec8d440 
Refs #11056
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
martyngigg added a commit that referenced this issue Feb 3, 2016
@martyngigg
Check for invalid irun fields and either exit or warn user.
240d0cc 
Refs #11056
martyngigg added a commit that referenced this issue Mar 3, 2016
@martyngigg
Read cuts from Horace correctly.
07a9f7d 
The dimension limit information is now read from the pax/iint fields. The
Q_lab frame as also been removed as it is not a sensible choice.
Refs #11056
martyngigg added a commit that referenced this issue Mar 3, 2016
@martyngigg
Return the number of events added with MDBoxBase::addEvent
2bf8abc 
This allows the caller to detector if an event was dropped from the
grid box.
Refs #11056
martyngigg added a commit that referenced this issue Mar 3, 2016
@martyngigg
Fix misunderstanding of frame of projection limits & pixels.
ddac749 
Refs #11056
martyngigg added a commit that referenced this issue Mar 4, 2016
@martyngigg
Clang format the test
b59dec8 
Refs #11056
martyngigg added a commit that referenced this issue Mar 4, 2016
@martyngigg
Merge branch 'master' into 11056_loadsqw_v2
5b5e2bb 
Conflicts:
	Framework/DataObjects/inc/MantidDataObjects/MDBox.h
	Framework/DataObjects/inc/MantidDataObjects/MDBox.tcc
	Framework/DataObjects/inc/MantidDataObjects/MDGridBox.h
Refs #11056
martyngigg added a commit that referenced this issue Mar 4, 2016
@martyngigg
Fix compilation issue arising from merge.
e45bebc 
Refs #11056
martyngigg added a commit that referenced this issue Mar 4, 2016
@martyngigg
Avoid ambiguous make_unique call on MSVC
192a80c 
Refs #11056
martyngigg added a commit that referenced this issue Mar 9, 2016
@martyngigg
Fix function that expands box limits.
5209c40 
It was ignoring the initial sign of the value and so sometimes the value
would move in the wrong direction.
Refs #11056
martyngigg added a commit that referenced this issue Mar 9, 2016
@martyngigg
Use brute force approach to finding the data limits.
e4d1640 
The MDEventWorkspace needs to know the full extent of the pixels to avoid
dropping any events when reading. The only surefire way is to compute the
coordinate limits from the pixels themselves.
Refs #11056
martyngigg added a commit that referenced this issue Mar 9, 2016
@martyngigg
Merge branch 'master' into 11056_loadsqw_v2
78bd30c 
Conflicts:
	Framework/DataObjects/test/MDBoxBaseTest.h
Refs #11056
martyngigg added a commit that referenced this issue Mar 9, 2016
@martyngigg
Clang format test file. Refs #11056
48c650a
martyngigg added a commit that referenced this issue Mar 9, 2016
@martyngigg
Fix doxygen warning.
8ca81dc 
Refs #11056
martyngigg added a commit that referenced this issue Mar 9, 2016
@martyngigg
Fix result of bad merge conflict resolution.
374cb1a 
Refs #11056
martyngigg added a commit that referenced this issue Mar 11, 2016
@martyngigg
Improve progress reporting to cover limit calculation.
77e497d 
Refs #11056
martyngigg added a commit that referenced this issue Mar 11, 2016
@martyngigg
Apply clang formatting
9e34058 
Refs #11056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martyngigg martyngigg

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 3.7
Development

No branches or pull requests
3 participants
@martyngigg @NickDraper @abuts