Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNSPowderReduction is broken when PreserveEvents=False #11067

Closed
martyngigg opened this issue Sep 10, 2014 · 1 comment
Closed

SNSPowderReduction is broken when PreserveEvents=False #11067

martyngigg opened this issue Sep 10, 2014 · 1 comment
Assignees
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone

Comments

@martyngigg
Copy link
Member

It was broken in this [https://github.com/mantidproject/mantid/commit/342aca3e08d3ec21be2627f2d380f85b8bb72bfb#diff-1b114ee94e8df86b22e2cac0469acd8b commit] with the addition of a logging statement that asks for the number of events (342aca3#diff-1b114ee94e8df86b22e2cac0469acd8bR660)

This has caused the [http://builds.mantidproject.org/view/Nightly%20Builds%20and%20Tests/job/master_clean_rhel6_mpi_systemtested/lastCompletedBuild/testReport/SystemTests/SNSPowderRedux/SeriesAndConjoinFilesTest/ MPI system tests] to fail as the PreserveEvents flag is force to false for an MPI build.

This script demonstrates the problem (based on the current master)

#!python

cal_file   = "PG3_FERNS_d4832_2011_08_24.cal"
char_file  = "PG3_characterization_2012_02_23-HR-ILL.txt"

# reduce a sum of runs - and drop it
SNSPowderReduction(Instrument="PG3", RunNumber=[9829,9830], Extension="_event.nxs",
           Sum=True, # This is the difference with the next call
           PreserveEvents=False, VanadiumNumber=-1,
           CalibrationFile=cal_file,
           CharacterizationRunsFile=char_file,
           LowResRef=15000, RemovePromptPulseWidth=50,
           Binning=-0.0004, BinInDspace=True, FilterBadPulses=True,
           SaveAs="gsas", OutputDirectory=os.path.expanduser("~/"),
           FinalDataUnits="dSpacing")

@martyngigg martyngigg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@martyngigg martyngigg added this to the Release 3.3 milestone Jun 3, 2015
@martyngigg
Copy link
Member Author

This issue was originally trac ticket 10225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

No branches or pull requests

2 participants