Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Reflectometry GUI needs search pane. #11234

Closed
OwenArnold opened this issue Oct 20, 2014 · 1 comment
Closed

New Reflectometry GUI needs search pane. #11234

OwenArnold opened this issue Oct 20, 2014 · 1 comment
Assignees
Labels
Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocks : TRAC10540

This has been implemented in the old reflectometry gui, and roughly we should duplicate the behaviour. There are a few things I would like to see in addition.

  1. The consumption of the ICAT search tools should be abstracted if possible. We have already had one occasion to switch the search tools from xml journal to icat, one could imagine this happening again.
  2. The functionality should continue to provide good and useful feedback such as allowing the user to login to ICAT in situ.
  3. There are currently as set of rules for transfer and grouping runs into rows and columns (ask Owen for details, but the code for this is in the old gui). This transfer logic should be encapsulated, the type should take in a TableWorkspace or some equivalent to perform the transfer on so that we can test the search functionality without the network. This transfer functionality would have access to the presented table workspace so that it could populate it. Also this type of transfer has been implemented for Max by Max, I'd like to have the ability to switch to different transfer strategies, as Max's one may not be universally liked.
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 10392

@OwenArnold OwenArnold added the Reflectometry Issues and pull requests related to reflectometry label Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.3 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

No branches or pull requests

2 participants