Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReflMainViewPresenter goes behind the model's back #11273

Closed
eXeC64 opened this issue Oct 27, 2014 · 1 comment
Closed

ReflMainViewPresenter goes behind the model's back #11273

eXeC64 opened this issue Oct 27, 2014 · 1 comment
Assignees
Labels
Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@eXeC64
Copy link
Contributor

eXeC64 commented Oct 27, 2014

This ticket is blocks : TRAC10440

Currently the presenter does not use the ReflTableModel to manipulate the table, it goes through the table workspace itself. This stops the model from receiving proper updates on what has changed, and therefore from updating the view correctly. To get around this currently, every time the presenter changes the table it is reloaded into the view. This means that selections and table settings cannot be preserved.

Instead of passing the ReflMainView a table workspace pointer, ReflMainViewPresenter should pass it a ReflTableModel which it shall use itself, allowing the table to be correctly updated.

@eXeC64
Copy link
Contributor Author

eXeC64 commented Jun 3, 2015

This issue was originally trac ticket 10431

@eXeC64 eXeC64 added the Reflectometry Issues and pull requests related to reflectometry label Jun 3, 2015
@eXeC64 eXeC64 self-assigned this Jun 3, 2015
@eXeC64 eXeC64 added this to the Release 3.3 milestone Jun 3, 2015
@eXeC64 eXeC64 closed this as completed Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

No branches or pull requests

1 participant