Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Coverity issues in ReflMainViewPresenter #11325

Closed
eXeC64 opened this issue Nov 3, 2014 · 1 comment
Closed

Fix Coverity issues in ReflMainViewPresenter #11325

eXeC64 opened this issue Nov 3, 2014 · 1 comment
Assignees
@eXeC64
Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done.
Milestone
Release 3.3

Comments

@eXeC64
Copy link
Contributor

eXeC64 commented Nov 3, 2014

m_view is dereferenced both before a null checked dereference, and after. So why are we null checking? Coverity suggests that all paths leading to the null check have a valid pointer, so the check is doubly superfluous, as there is no possibility of a null pointer, and if there were one, it wouldn't protect us in its current state.
@eXeC64 eXeC64 added Low Priority Things that you don't ever want to be done. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@eXeC64 eXeC64 self-assigned this Jun 3, 2015
@eXeC64 eXeC64 added this to the Release 3.3 milestone Jun 3, 2015
@eXeC64
Copy link
Contributor Author

eXeC64 commented Jun 3, 2015

This issue was originally trac ticket 10483

@eXeC64 eXeC64 closed this as completed Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eXeC64 eXeC64

Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done.
Projects
None yet
Milestone
Release 3.3
Development

No branches or pull requests
1 participant
@eXeC64