Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitting result changes depending on log level #11357

Closed
MichaelWedel opened this issue Nov 7, 2014 · 3 comments
Closed

Fitting result changes depending on log level #11357

MichaelWedel opened this issue Nov 7, 2014 · 3 comments
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@MichaelWedel
Copy link
Contributor

This issue was originally TRAC 10515

While I was doing some experimental work on POLDI 2D-fitting, I discovered that the result depends on the log level. For log-level information or debug, the fit converges differently and gives a different result.

Since this was experimental work, I will just push the small changes I made to reproduce this problem.

@MichaelWedel
Copy link
Contributor Author

@MichaelWedel (2014-11-07T14:52:09):
Refs http://trac.mantidproject.org/mantid/ticket/10515. Adding latest parameters for comparison.

Current software works with those parameters, so for comparison they are required.

4d92843


@MichaelWedel (2014-11-07T14:52:09):
Refs http://trac.mantidproject.org/mantid/ticket/10515. Small changes to PoldiCalculateSpectrum2D

06dafd9


@MichaelWedel (2014-11-07T15:04:10):
Refs http://trac.mantidproject.org/mantid/ticket/10515. Adding test data

3f4e305


@MichaelWedel (2014-11-07T15:05:41):
Script (UsageData-directory must be configured as data directory):

fileRange = range(73,76)

workspaces = []
for i in fileRange:
    wsName = "243%s" % (i)
    workspaces.append(wsName)
    LoadSINQFile("poldi2014n0243%s.hdf" % (i), "POLDI", OutputWorkspace=wsName)
    LoadInstrument(wsName, InstrumentName="POLDI")

SiWs = GroupWorkspaces(InputWorkspaces=','.join(workspaces))
Merged=PoldiMerge(SiWs)

PoldiAutoCorrelation(InputWorkspace='Merged', OutputWorkspace='corr')
PoldiPeakSearch(InputWorkspace='corr', MaximumPeakNumber=30, OutputWorkspace='corrPeaks')
PoldiFitPeaks1D(InputWorkspace='corr', FwhmMultiples=4, PoldiPeakTable='corrPeaks')
DeleteTableRows(TableWorkspace='RefinedPeakTable', Rows='10-15')
PoldiCalculateSpectrum2D(InputWorkspace='Merged', PoldiPeakWorkspace='RefinedPeakTable', PeakProfileFunction='Gaussian', OutputWorkspace='d')

@MichaelWedel MichaelWedel added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@FedeMPouzols
Copy link
Contributor

@MichaelWedel : for when you're back, I think that this issue was solved as #12948. And by the way we 'fixed' one of your Poldi tests for that change (see PR #12961) so please close this issue if you think that the problem is gone now.

@MichaelWedel
Copy link
Contributor Author

As suggested by @FedeMPouzols, the issue has been solved in another context, so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

3 participants