Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible/sensible to remove the AlgorithmProxy class #11360

Closed
martyngigg opened this issue Nov 7, 2014 · 3 comments
Closed

Is it possible/sensible to remove the AlgorithmProxy class #11360

martyngigg opened this issue Nov 7, 2014 · 3 comments
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects

Comments

@martyngigg
Copy link
Member

This issue was originally TRAC 10518

Several recent issues, http://trac.mantidproject.org/mantid/ticket/10438 & http://trac.mantidproject.org/mantid/ticket/10377, have uncovered problems with the AlgorithmProxy not correctly mirroring Algorithm. Obviously these can be fixed but do we need to class at all these days given that we no longer return algorithm objects in Python (its original use case).

This ticket is to investigate whether it is feasible and sensible to do the removal.


Keywords: Maintenance

@martyngigg
Copy link
Member Author

@mantid-roman (2014-11-07T16:55:30):
AlgorithmManager keeps a few pointers. Do we need it when we use notifications?


@martyngigg (2014-11-07T17:12:51):
For MantidPlot we will need to store the pointer somewhere for the asynchronous runs but I don't really see why the manager needs to keep anything past it having finished.

It's a good thing to bear in mind though when we look in to it.

@martyngigg martyngigg added Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@martyngigg martyngigg self-assigned this Jun 3, 2015
@martyngigg martyngigg added this to the Release 3.6 milestone Jun 3, 2015
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
@NickDraper NickDraper modified the milestones: Release 3.7, Release 3.8 May 20, 2016
@peterfpeterson peterfpeterson added this to To do in Maintenance Nov 20, 2018
@martyngigg martyngigg removed their assignment Jul 15, 2019
@martyngigg
Copy link
Member Author

This doesn't need to be done by me so I'm leaving it for the general maintenance pool.

@martyngigg
Copy link
Member Author

Duplicate of #28407

@martyngigg martyngigg marked this as a duplicate of #28407 Aug 7, 2020
Maintenance automation moved this from Icebox to Done Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
No open projects
Development

No branches or pull requests

2 participants