Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency, code quality and usability of MDNormDirectSC #11672

Closed
1 task done
abuts opened this issue Dec 18, 2014 · 2 comments
Closed
1 task done

Improve efficiency, code quality and usability of MDNormDirectSC #11672

abuts opened this issue Dec 18, 2014 · 2 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@abuts
Copy link
Member

abuts commented Dec 18, 2014

This issue was originally TRAC 10830

This ticket is blocked by :

This is mainly thought which can be spread into separate tickets or dealt all together

  1. Why to calculate detector positions in the algorithm when convertToMD have just calculated them using PreprocessDetectorsToMd and placed them into separate workspace for further usage? It is expensive operation.

  2. Enable OMP in the algorithm (after logical bugs are fixed)

  3. in 90% of cases one wants to obtain normalized workspace of the size of the source workspace. Why to combine MDNormDirectSC with rebin and allow it to work on part of the workspace? If this feature is important, at least the algorithm with empty dimension parameters should pick up binning ranges from source workspace.

  4. Create meaningful unit test for the algorithm

@abuts
Copy link
Member Author

abuts commented Dec 19, 2014

@AndreiSavici (2014-12-19T20:01:43):
Usage example for MDNormDirectSC. Refs http://trac.mantidproject.org/mantid/ticket/10829

Also enabled the parallel processing. Refs http://trac.mantidproject.org/mantid/ticket/10830

e9e0dd6

@abuts abuts added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
MichaelWedel pushed a commit that referenced this issue Jun 5, 2015
MichaelWedel pushed a commit that referenced this issue Jun 5, 2015
MichaelWedel pushed a commit that referenced this issue Jun 5, 2015
@AndreiSavici
Copy link
Member

  1. We don't know if the geometry is constant between runs
  2. Done
  3. Implemented in MDNorm
  4. Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

2 participants